[lldb] Clear loaded sections even earlier

labath · labath · commit 7e7871d3f58b · 2025-05-14T15:38:10.000+02:00
Follow-up to llvm#138892 fixing breakage on windows. Calling ClearAllLoadedSections earlier is necessary to avoid throwing out the work done by the windows process plugin.
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
@@ -2675,6 +2675,7 @@ Status Process::LaunchPrivate(ProcessLaunchInfo &launch_info, StateType &state,
   m_jit_loaders_up.reset();
   m_system_runtime_up.reset();
   m_os_up.reset();
+  GetTarget().ClearAllLoadedSections();
 
   {
     std::lock_guard<std::mutex> guard(m_process_input_reader_mutex);
@@ -2763,7 +2764,6 @@ Status Process::LaunchPrivate(ProcessLaunchInfo &launch_info, StateType &state,
   }
 
   if (state == eStateStopped || state == eStateCrashed) {
-    GetTarget().ClearAllLoadedSections();
     DidLaunch();
 
     // Now that we know the process type, update its signal responses from the

Original file line number	Diff line number	Diff line change
`@@ -2675,6 +2675,7 @@ Status Process::LaunchPrivate(ProcessLaunchInfo &launch_info, StateType &state,`
`2675`	`2675`	`m_jit_loaders_up.reset();`
`2676`	`2676`	`m_system_runtime_up.reset();`
`2677`	`2677`	`m_os_up.reset();`
	`2678`	`+ GetTarget().ClearAllLoadedSections();`
`2678`	`2679`
`2679`	`2680`	`{`
`2680`	`2681`	`std::lock_guard<std::mutex> guard(m_process_input_reader_mutex);`
`@@ -2763,7 +2764,6 @@ Status Process::LaunchPrivate(ProcessLaunchInfo &launch_info, StateType &state,`
`2763`	`2764`	`}`
`2764`	`2765`
`2765`	`2766`	`if (state == eStateStopped \|\| state == eStateCrashed) {`
`2766`		`- GetTarget().ClearAllLoadedSections();`
`2767`	`2767`	`DidLaunch();`
`2768`	`2768`
`2769`	`2769`	`// Now that we know the process type, update its signal responses from the`