Fix CI, add BUILD_TESTS and remove catkin support

Author: facontidavide

.github/workflows/cmake_ubuntu.yml

@@ -1,6 +1,11 @@
 name: cmake Ubuntu
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
@@ -15,22 +20,17 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-20.04]
+        os: [ubuntu-22.04]
 
     steps:
     - uses: actions/checkout@v2
 
     - name: Install Conan
       id: conan
       uses: turtlebrowser/get-conan@main
-      with:
-        version: 1.59.0
 
     - name: Create default profile
-      run: conan profile new default --detect
-
-    - name: Update profile
-      run: conan profile update settings.compiler.libcxx=libstdc++11 default
+      run: conan profile detect
 
     - name: Create Build Environment
       # Some projects don't allow in-source building, so create a separate build directory
@@ -44,16 +44,16 @@ jobs:
     - name: Configure CMake
       shell: bash
       working-directory: ${{github.workspace}}/build
-      run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake
+      run: cmake ${{github.workspace}} -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake
 
     - name: Build
       shell: bash
       working-directory: ${{github.workspace}}/build
       run: cmake --build . --config ${{env.BUILD_TYPE}}
 
     - name: run test (Linux)
-      working-directory: ${{github.workspace}}/build
-      run: ./tests/behaviortree_cpp_test
+      working-directory: ${{github.workspace}}/build/tests
+      run: ctest
 
     - name: Upload coverage reports to Codecov
       uses: codecov/codecov-action@v3

.github/workflows/cmake_windows.yml

@@ -1,6 +1,11 @@
 name: cmake Windows
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 env:
   # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

.github/workflows/pixi.yaml

@@ -1,6 +1,11 @@
 name: Pixi (conda)
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 jobs:
   pixi_conda_build:

.github/workflows/pre-commit.yaml

@@ -1,9 +1,11 @@
 name: pre-commit
 
 on:
-  pull_request:
   push:
-    branches: [master]
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 jobs:
   pre-commit:

.github/workflows/ros1.yaml

@@ -1,6 +1,11 @@
 name: ros2-rolling
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 jobs:
   industrial_ci:

.github/workflows/ros2-rolling.yaml

@@ -1,6 +1,11 @@
 name: ros2
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types: [opened, synchronize, reopened]
 
 jobs:
   industrial_ci:

.github/workflows/ros2.yaml

@@ -1,10 +1,12 @@
 name: Sonarcube Scan
+
 on:
   push:
     branches:
       - master
   pull_request:
     types: [opened, synchronize, reopened]
+
 jobs:
   build:
     name: Build

.github/workflows/sonarcube.yml

@@ -9,7 +9,7 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 option(BTCPP_SHARED_LIBS "Build shared libraries" ON)
 option(BTCPP_BUILD_TOOLS "Build commandline tools" ON)
 option(BTCPP_EXAMPLES   "Build tutorials and examples" ON)
-option(BTCPP_UNIT_TESTS "Build the unit tests" ON)
+option(BUILD_TESTING "Build the unit tests" ON)
 option(BTCPP_GROOT_INTERFACE "Add Groot2 connection. Requires ZeroMQ" ON)
 option(BTCPP_SQLITE_LOGGING "Add SQLite logging." ON)
 
@@ -82,15 +82,6 @@ if ( ament_cmake_FOUND )
     message(STATUS "BehaviorTree is being built using AMENT.")
     message(STATUS "------------------------------------------")
     include(cmake/ament_build.cmake)
-
-elseif( CATKIN_DEVEL_PREFIX OR CATKIN_BUILD_BINARY_PACKAGE)
-
-    add_definitions( -DUSING_ROS )
-    message(STATUS "------------------------------------------")
-    message(STATUS "BehaviorTree is being built using CATKIN.")
-    message(STATUS "------------------------------------------")
-    include(cmake/catkin_build.cmake)
-    set(catkin_FOUND TRUE)
 else()
     message(STATUS "------------------------------------------")
     message(STATUS "BehaviorTree is being built with conan.")
@@ -229,15 +220,16 @@ endif()
 #############################################################
 message( STATUS "BTCPP_LIB_DESTINATION:   ${BTCPP_LIB_DESTINATION} " )
 message( STATUS "BTCPP_INCLUDE_DESTINATION: ${BTCPP_INCLUDE_DESTINATION} " )
-message( STATUS "BTCPP_UNIT_TESTS:   ${BTCPP_UNIT_TESTS} " )
 
-if (BTCPP_UNIT_TESTS OR BTCPP_EXAMPLES)
+if (BUILD_TESTING OR BTCPP_EXAMPLES)
     add_subdirectory(sample_nodes)
 endif()
 
 ######################################################
 
-if (BTCPP_UNIT_TESTS)
+include(CTest)
+message( STATUS "BUILD_TESTING:   ${BUILD_TESTING} " )
+if (BUILD_TESTING)
     add_subdirectory(tests)
 endif()
 

CMakeLists.txt

@@ -55,7 +55,6 @@ If you are looking for a more fancy graphical user interface (and I know you do)
 
 Three build systems are supported:
 
-- **catkin**, if you use ROS
 - **colcon (ament)**, if you use ROS2
 - **conan** otherwise (Linux/Windows).
 - **straight cmake** if you want to be personally responsible for dependencies :)

README.md

@@ -279,9 +279,8 @@ class BehaviorTreeFactory
   /**
      * @brief registerFromROSPlugins finds all shared libraries that export ROS plugins for behaviortree_cpp, and calls registerFromPlugin for each library.
      * @throws If not compiled with ROS support or if the library cannot load for any reason
-     *
      */
-  void registerFromROSPlugins();
+  [[deprecated("Removed support for ROS1")]] void registerFromROSPlugins();
 
   /**
      * @brief registerBehaviorTreeFromFile.

cmake/catkin_build.cmake

@@ -14,8 +14,6 @@
 
   <build_depend>ros_environment</build_depend>
 
-  <buildtool_depend condition="$ROS_VERSION == 1">catkin</buildtool_depend>
-  <depend condition="$ROS_VERSION == 1">roslib</depend>
 
   <buildtool_depend condition="$ROS_VERSION == 2">ament_cmake</buildtool_depend>
   <depend condition="$ROS_VERSION == 2">rclcpp</depend>
@@ -27,7 +25,6 @@
   <test_depend condition="$ROS_VERSION == 2">ament_cmake_gtest</test_depend>
 
   <export>
-      <build_type condition="$ROS_VERSION == 1">catkin</build_type>
       <build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>
   </export>
 

include/behaviortree_cpp/bt_factory.h

@@ -17,10 +17,6 @@
 #include "behaviortree_cpp/xml_parsing.h"
 #include "wildcards/wildcards.hpp"
 
-#ifdef USING_ROS
-#include <ros/package.h>
-#endif
-
 namespace BT
 {
 
@@ -196,66 +192,12 @@ void BehaviorTreeFactory::registerFromPlugin(const std::string& file_path)
   }
 }
 
-#ifdef USING_ROS
-
-#ifdef _WIN32
-const char os_pathsep(';');  // NOLINT
-#else
-const char os_pathsep(':');  // NOLINT
-#endif
-
-// This function is a copy from the one in class_loader_imp.hpp in ROS pluginlib
-// package, licensed under BSD.
-// https://github.com/ros/pluginlib
-std::vector<std::string> getCatkinLibraryPaths()
-{
-  std::vector<std::string> lib_paths;
-  const char* env = std::getenv("CMAKE_PREFIX_PATH");
-  if(env)
-  {
-    const std::string env_catkin_prefix_paths(env);
-    std::vector<BT::StringView> catkin_prefix_paths =
-        splitString(env_catkin_prefix_paths, os_pathsep);
-    for(BT::StringView catkin_prefix_path : catkin_prefix_paths)
-    {
-      std::filesystem::path path(static_cast<std::string>(catkin_prefix_path));
-      std::filesystem::path lib("lib");
-      lib_paths.push_back((path / lib).string());
-    }
-  }
-  return lib_paths;
-}
-
-void BehaviorTreeFactory::registerFromROSPlugins()
-{
-  std::vector<std::string> plugins;
-  ros::package::getPlugins("behaviortree_cpp", "bt_lib_plugin", plugins, true);
-  std::vector<std::string> catkin_lib_paths = getCatkinLibraryPaths();
-
-  for(const auto& plugin : plugins)
-  {
-    auto filename = std::filesystem::path(plugin + BT::SharedLibrary::suffix());
-    for(const auto& lib_path : catkin_lib_paths)
-    {
-      const auto full_path = std::filesystem::path(lib_path) / filename;
-      if(std::filesystem::exists(full_path))
-      {
-        std::cout << "Registering ROS plugins from " << full_path.string() << std::endl;
-        registerFromPlugin(full_path.string());
-        break;
-      }
-    }
-  }
-}
-#else
-
 void BehaviorTreeFactory::registerFromROSPlugins()
 {
   throw RuntimeError("Using attribute [ros_pkg] in <include>, but this library was "
                      "compiled without ROS support. Recompile the BehaviorTree.CPP "
                      "using catkin");
 }
-#endif
 
 void BehaviorTreeFactory::registerBehaviorTreeFromFile(
     const std::filesystem::path& filename)

package.xml

@@ -36,10 +36,6 @@
 #include "tinyxml2/tinyxml2.h"
 #include <filesystem>
 
-#ifdef USING_ROS
-#include <ros/package.h>
-#endif
-
 #ifdef USING_ROS2
 #include <ament_index_cpp/get_package_share_directory.hpp>
 #endif
@@ -283,9 +279,7 @@ void XMLParser::PImpl::loadDocImpl(XMLDocument* doc, bool add_includes)
       else
       {
         std::string ros_pkg_path;
-#ifdef USING_ROS
-        ros_pkg_path = ros::package::getPath(ros_pkg_relative_path);
-#elif defined USING_ROS2
+#if defined USING_ROS2
         ros_pkg_path =
             ament_index_cpp::get_package_share_directory(ros_pkg_relative_path);
 #else