Work in progress on auth helper

Author: Luciano Nooijen

.env.example

@@ -25,4 +25,4 @@ DB_PASS_TEST=root
 # Authentication
 SALT_ROUNDS=10
 JWT_SECRET=secret
-JWT_EXPIRES_IN=7d
+JWT_EXPIRES_IN_DAYS=7

helpers/auth-helper.js

@@ -1,9 +1,11 @@
 const bcrypt = require('bcrypt');
+const jwt = require('jwt-simple');
 
-const { SALT_ROUNDS, JWT_SECRET, JWT_EXPIRES_IN } = process.env;
+const { SALT_ROUNDS, JWT_SECRET, JWT_EXPIRES_IN_DAYS } = process.env;
 
 const decimalRadix = 10;
 const saltRounds = parseInt(SALT_ROUNDS, decimalRadix);
+const jwtExpiresInDays = parseInt(JWT_EXPIRES_IN_DAYS, decimalRadix);
 
 const generatePasswordHash = async plainTextPassword => {
     const hashedPassword = await new Promise((resolve, reject) =>
@@ -25,18 +27,39 @@ const checkPasswordHash = async (plainTextPassword, hashedPassword) => {
     return false;
 };
 
-const generateJWT = () => {
-    return null;
+const calculateExpiryDate = () => {
+    const date = new Date();
+    const expiryDate = date.setDate(date.getDate() + jwtExpiresInDays);
+    return expiryDate;
 };
 
-// TODO: Integrate Typescript, generate enum
-const checkJWT = () => {};
+// TODO: Make it possible to mock payload of x days ago
+const generatePayload = data => {
+    const payload = {
+        expires: calculateExpiryDate(),
+        data,
+    };
+    return payload;
+};
+
+const generateJWT = data => {
+    const payload = generatePayload(data);
+    const token = jwt.encode(payload, JWT_SECRET);
+    return token;
+};
+
+const decodeJWT = token => {
+    const decoded = jwt.decode(token, JWT_SECRET);
+    return decoded;
+};
 
 const authHelper = {
+    calculateExpiryDate,
+    generatePayload,
     generatePasswordHash,
     checkPasswordHash,
     generateJWT,
-    checkJWT,
+    decodeJWT,
 };
 
 module.exports = authHelper;

package.json

@@ -45,6 +45,7 @@
     "dotenv": "^6.1.0",
     "express": "^4.16.4",
     "helmet": "^3.15.0",
+    "jwt-simple": "^0.5.5",
     "knex": "^0.15.2",
     "morgan": "^1.9.1",
     "pg": "^7.6.1",

tests/helpers/auth-helper.test.ts

@@ -1,13 +1,11 @@
-import { useEnvVars } from '../config/index';
-
 const { authHelper } = require('../../helpers');
 
+const { JWT_SECRET, JWT_EXPIRES_IN_DAYS } = process.env;
+
 const testPassword = 'the_test_password';
 const getPasswordHash = async () =>
     authHelper.generatePasswordHash(testPassword);
 
-useEnvVars();
-
 describe('Authentication helper', () => {
     test('generatePasswordHash should not return the password', async () => {
         expect.assertions(1);
@@ -28,7 +26,54 @@ describe('Authentication helper', () => {
         expect(passwordCheck).toBe(true);
     });
 
-    // test('generateJWT should return a string', () => {
-    //     const authToken = authHelper.generateAuthToken()
-    // });
+    test('generateJWT should return a string', () => {
+        const payloadData = {
+            user: 'Test',
+        };
+        const authToken = authHelper.generateJWT(payloadData);
+        expect(typeof authToken).toBe('string');
+    });
+
+    test('decodeJWT should return the correct payload', () => {
+        const payloadData = {
+            user: 'Test',
+        };
+        const payload = authHelper.generatePayload(payloadData);
+        const authToken = authHelper.generateJWT(payloadData);
+        const decodedPayload = authHelper.decodeJWT(authToken);
+        expect(decodedPayload).toEqual(payload);
+    });
+
+    test('JWT expiry data create a valid date object', () => {
+        const payload = {
+            user: 'Test',
+        };
+        const authToken = authHelper.generateJWT(payload);
+        const decodedPayload = authHelper.decodeJWT(authToken);
+        const payloadDate = new Date(decodedPayload.expires);
+        expect(payloadDate).toBeInstanceOf(Date);
+    });
+
+    test('JWT expiry date should be in the future', () => {
+        const payload = {
+            user: 'Test',
+        };
+        const authToken = authHelper.generateJWT(payload);
+        const decodedPayload = authHelper.decodeJWT(authToken);
+        const payloadDate = decodedPayload.expires;
+        expect(payloadDate).toBeGreaterThan(Date.now());
+    });
+
+    test('JWT should expire in JWT_EXPIRES_IN_DAYS days', () => {
+        const payload = {
+            user: 'Test',
+        };
+        const authToken = authHelper.generateJWT(payload);
+        const decodedPayload = authHelper.decodeJWT(authToken);
+        const payloadDate = decodedPayload.expires;
+        const expectedExpiryDate = authHelper.calculateExpiryDate();
+
+        // Precise to 10 seconds TODO: Test this better
+        expect(Math.floor(payloadDate / 10)).toBe(Math.floor(expectedExpiryDate / 10));
+    });
 });

tests/knexfile-generator.test.ts

@@ -1,15 +1,11 @@
 /* eslint-disable function-paren-newline */
 
-import { useEnvVars } from './config/index';
-
 const generateKnexConfig = require('../database/generate-knexfile');
 const {
     getNodeEnvSpecificDefaults,
     getConfigEntry,
 } = require('../database/generate-knexfile');
 
-useEnvVars();
-
 const {
     NODE_ENV,
     KNEX_DEBUG,

yarn.lock

@@ -3826,6 +3826,11 @@ jsx-ast-utils@^2.0.1:
   dependencies:
     array-includes "^3.0.3"
 
+jwt-simple@^0.5.5:
+  version "0.5.5"
+  resolved "https://registry.yarnpkg.com/jwt-simple/-/jwt-simple-0.5.5.tgz#53f60ceab266708450a22cafa6fd93cfa2ccfa3a"
+  integrity sha512-KEyanRIDHooo8KuBxY3CC019NbwHtxdsxzRJUfaGqcxMrvBPBkosN+RUxx1nZFI6yrErq3KTW8HI/qrNIxHe0g==
+
 kind-of@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/kind-of/-/kind-of-1.1.0.tgz#140a3d2d41a36d2efcfa9377b62c24f8495a5c44"