Skip to content

Commit 21d370e

Browse files
Bump SpeziFirebase to fix login transition bug (#5)
# Bump SpeziFirebase to fix login transition bug ## ⚙️ Release Notes * Bump SpeziFirebase version to fix minor regression. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/CS342/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/CS342/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/CS342/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/CS342/.github/blob/main/CONTRIBUTING.md). --------- Co-authored-by: Paul Schmiedmayer <PSchmiedmayer@users.noreply.github.com>
1 parent a4778d6 commit 21d370e

File tree

5 files changed

+50
-50
lines changed

5 files changed

+50
-50
lines changed

CS342ExampleApplication.xcodeproj/project.pbxproj

+4-4
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,7 @@
11451145
repositoryURL = "https://github.com/StanfordSpezi/SpeziFirebase.git";
11461146
requirement = {
11471147
kind = upToNextMajorVersion;
1148-
minimumVersion = 2.0.0;
1148+
minimumVersion = 2.0.1;
11491149
};
11501150
};
11511151
2FE5DC8229EDD934004B9AB4 /* XCRemoteSwiftPackageReference "SpeziQuestionnaire" */ = {
@@ -1161,23 +1161,23 @@
11611161
repositoryURL = "https://github.com/StanfordSpezi/SpeziStorage.git";
11621162
requirement = {
11631163
kind = upToNextMajorVersion;
1164-
minimumVersion = 1.2.1;
1164+
minimumVersion = 1.2.3;
11651165
};
11661166
};
11671167
2FE5DC8D29EDD980004B9AB4 /* XCRemoteSwiftPackageReference "SpeziViews" */ = {
11681168
isa = XCRemoteSwiftPackageReference;
11691169
repositoryURL = "https://github.com/StanfordSpezi/SpeziViews.git";
11701170
requirement = {
11711171
kind = upToNextMajorVersion;
1172-
minimumVersion = 1.8.0;
1172+
minimumVersion = 1.9.0;
11731173
};
11741174
};
11751175
2FE5DC9029EDD9C3004B9AB4 /* XCRemoteSwiftPackageReference "firebase-ios-sdk" */ = {
11761176
isa = XCRemoteSwiftPackageReference;
11771177
repositoryURL = "https://github.com/firebase/firebase-ios-sdk.git";
11781178
requirement = {
11791179
kind = upToNextMajorVersion;
1180-
minimumVersion = 11.0.0;
1180+
minimumVersion = 11.8.0;
11811181
};
11821182
};
11831183
2FE5DC9729EDD9D9004B9AB4 /* XCRemoteSwiftPackageReference "XCTestExtensions" */ = {

CS342ExampleApplication.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

+34-34
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
"kind" : "remoteSourceControl",
2525
"location" : "https://github.com/google/app-check.git",
2626
"state" : {
27-
"revision" : "87dd288fc792bf9751e522e171a47df5b783b0b8",
28-
"version" : "11.1.0"
27+
"revision" : "61b85103a1aeed8218f17c794687781505fbbef5",
28+
"version" : "11.2.0"
2929
}
3030
},
3131
{
@@ -42,8 +42,8 @@
4242
"kind" : "remoteSourceControl",
4343
"location" : "https://github.com/krzyzanowskim/CryptoSwift.git",
4444
"state" : {
45-
"revision" : "678d442c6f7828def400a70ae15968aef67ef52d",
46-
"version" : "1.8.3"
45+
"revision" : "729e01bc9b9dab466ac85f21fb9ee2bc1c61b258",
46+
"version" : "1.8.4"
4747
}
4848
},
4949
{
@@ -60,17 +60,17 @@
6060
"kind" : "remoteSourceControl",
6161
"location" : "https://github.com/firebase/firebase-ios-sdk.git",
6262
"state" : {
63-
"revision" : "f909f901bfba9e27e4e9da83242a4915d6dd64bb",
64-
"version" : "11.3.0"
63+
"revision" : "6318278e8e64d21f0fdcc69004395e4d34048aaf",
64+
"version" : "11.8.1"
6565
}
6666
},
6767
{
6868
"identity" : "googleappmeasurement",
6969
"kind" : "remoteSourceControl",
7070
"location" : "https://github.com/google/GoogleAppMeasurement.git",
7171
"state" : {
72-
"revision" : "93406fd21b85e66e2d6dbf50b472161fd75c3f1f",
73-
"version" : "11.3.0"
72+
"revision" : "be0881ff728eca210ccb628092af400c086abda3",
73+
"version" : "11.7.0"
7474
}
7575
},
7676
{
@@ -105,17 +105,17 @@
105105
"kind" : "remoteSourceControl",
106106
"location" : "https://github.com/google/gtm-session-fetcher.git",
107107
"state" : {
108-
"revision" : "a2ab612cb980066ee56d90d60d8462992c07f24b",
109-
"version" : "3.5.0"
108+
"revision" : "3cdb78efb79b4a5383c3911488d8025bfc545b5e",
109+
"version" : "4.3.0"
110110
}
111111
},
112112
{
113113
"identity" : "healthkitonfhir",
114114
"kind" : "remoteSourceControl",
115115
"location" : "https://github.com/StanfordBDHG/HealthKitOnFHIR.git",
116116
"state" : {
117-
"revision" : "87a9257e6fa37407f3437e4a0bf21dd09a4ea7c5",
118-
"version" : "0.2.11"
117+
"revision" : "c898c0bace660ecae37fc682d629f7883f92e700",
118+
"version" : "0.2.13"
119119
}
120120
},
121121
{
@@ -168,8 +168,8 @@
168168
"kind" : "remoteSourceControl",
169169
"location" : "https://github.com/StanfordBDHG/ResearchKitOnFHIR.git",
170170
"state" : {
171-
"revision" : "d8d8b0d01599ad8a5a8397d10a99073728e6ae9b",
172-
"version" : "2.0.2"
171+
"revision" : "2c70b9dc7a1be9c804222e93d1737be9fca9af84",
172+
"version" : "2.0.3"
173173
}
174174
},
175175
{
@@ -213,17 +213,17 @@
213213
"kind" : "remoteSourceControl",
214214
"location" : "https://github.com/StanfordSpezi/SpeziFirebase.git",
215215
"state" : {
216-
"revision" : "7c6829624884f6f1d700e0316b2580b39d3b0c5f",
217-
"version" : "2.0.0"
216+
"revision" : "5dd57f9de42c02d6a94f3af4d8cf3d9b81ec6661",
217+
"version" : "2.0.1"
218218
}
219219
},
220220
{
221221
"identity" : "spezifoundation",
222222
"kind" : "remoteSourceControl",
223-
"location" : "https://github.com/StanfordSpezi/SpeziFoundation.git",
223+
"location" : "https://github.com/StanfordSpezi/SpeziFoundation",
224224
"state" : {
225-
"revision" : "5b4ad1b343154b52a68c33a6bfe02d9cb07cb9dc",
226-
"version" : "2.0.0"
225+
"revision" : "c844b98242829fe44e7908739374d4c8b88d6da7",
226+
"version" : "2.1.0"
227227
}
228228
},
229229
{
@@ -247,10 +247,10 @@
247247
{
248248
"identity" : "spezinotifications",
249249
"kind" : "remoteSourceControl",
250-
"location" : "https://github.com/StanfordSpezi/SpeziNotifications",
250+
"location" : "https://github.com/StanfordSpezi/SpeziNotifications.git",
251251
"state" : {
252-
"revision" : "7f24fce6b969d0f1a7bcc0e228af1c01e55fb59f",
253-
"version" : "1.0.2"
252+
"revision" : "b886f192282a925f600ec5ecbc94acfc75460293",
253+
"version" : "1.0.3"
254254
}
255255
},
256256
{
@@ -276,26 +276,26 @@
276276
"kind" : "remoteSourceControl",
277277
"location" : "https://github.com/StanfordSpezi/SpeziScheduler.git",
278278
"state" : {
279-
"revision" : "a4923dcdcc46d7edf0a7bf7ea9d9531d40abe147",
280-
"version" : "1.1.0"
279+
"revision" : "deb213f0be235c8cb606e2bb1a195f475637df2d",
280+
"version" : "1.1.1"
281281
}
282282
},
283283
{
284284
"identity" : "spezistorage",
285285
"kind" : "remoteSourceControl",
286286
"location" : "https://github.com/StanfordSpezi/SpeziStorage.git",
287287
"state" : {
288-
"revision" : "0f4a54430e51f82d29da63a7ce5f61bad7dfb9cd",
289-
"version" : "1.2.1"
288+
"revision" : "935a7e121d7235a394a2c744ba8b83fd52f71ece",
289+
"version" : "1.2.3"
290290
}
291291
},
292292
{
293293
"identity" : "speziviews",
294294
"kind" : "remoteSourceControl",
295295
"location" : "https://github.com/StanfordSpezi/SpeziViews.git",
296296
"state" : {
297-
"revision" : "69b085705f2af4c5dfe93278a228c12caa6c3379",
298-
"version" : "1.8.0"
297+
"revision" : "80c7cdfd5e50c3e279ab889cc90bbcfc88c4f24c",
298+
"version" : "1.9.0"
299299
}
300300
},
301301
{
@@ -348,8 +348,8 @@
348348
"kind" : "remoteSourceControl",
349349
"location" : "https://github.com/FelixHerrmann/swift-package-list",
350350
"state" : {
351-
"revision" : "e84b63c88f0797d769732440fe0786c5a2c634d8",
352-
"version" : "4.4.0"
351+
"revision" : "5e954ec39ce2374ff28a38224fd4e6bba7c57cdc",
352+
"version" : "4.4.2"
353353
}
354354
},
355355
{
@@ -375,8 +375,8 @@
375375
"kind" : "remoteSourceControl",
376376
"location" : "https://github.com/realm/SwiftLint.git",
377377
"state" : {
378-
"revision" : "25f2776977e663305bee71309ea1e34d435065f1",
379-
"version" : "0.57.1"
378+
"revision" : "eba420f77846e93beb98d516b225abeb2fef4ca2",
379+
"version" : "0.58.2"
380380
}
381381
},
382382
{
@@ -402,8 +402,8 @@
402402
"kind" : "remoteSourceControl",
403403
"location" : "https://github.com/StanfordBDHG/XCTestExtensions.git",
404404
"state" : {
405-
"revision" : "5379d70249cae926927105bfb6686770f03ee5b9",
406-
"version" : "1.1.0"
405+
"revision" : "03eb0646dbceededbbb9d46b289f6eb50a4ec791",
406+
"version" : "1.1.2"
407407
}
408408
},
409409
{

CS342ExampleApplication/Resources/Localizable.xcstrings

+3-10
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@
4040
}
4141
}
4242
}
43+
},
44+
"Cats are great!" : {
45+
4346
},
4447
"Close" : {
4548
"localizations" : {
@@ -351,16 +354,6 @@
351354
}
352355
}
353356
},
354-
"The Spezi Framework" : {
355-
"localizations" : {
356-
"en" : {
357-
"stringUnit" : {
358-
"state" : "translated",
359-
"value" : "The Spezi Framework"
360-
}
361-
}
362-
}
363-
},
364357
"This type of event is currently unsupported. Please contact the developer of this app." : {
365358
"localizations" : {
366359
"en" : {

CS342ExampleApplicationUITests/OnboardingTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ extension XCUIApplication {
100100
buttons["Logout"].tap()
101101
}
102102

103-
XCTAssertTrue(buttons["Signup"].exists)
103+
XCTAssertTrue(buttons["Signup"].waitForExistence(timeout: 2))
104104
buttons["Signup"].tap()
105105

106106

CS342ExampleApplicationUITests/SchedulerTests.swift

+8-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class SchedulerTests: XCTestCase {
2020
app.deleteAndLaunch(withSpringboardAppName: "CS342ExampleApplication")
2121
}
2222

23-
23+
2424
@MainActor
2525
func testScheduler() throws {
2626
let app = XCUIApplication()
@@ -61,6 +61,13 @@ class SchedulerTests: XCTestCase {
6161
XCTAssert(app.staticTexts["E-mail"].exists)
6262
app.staticTexts["E-mail"].tap()
6363

64+
XCTAssert(nextButton.isEnabled)
65+
nextButton.tap()
66+
67+
// staticTexts["What is your e-mail?"] is not exposed in the accessibility hierarchy; it seems like a bug in ResearchKit.
68+
XCTAssert(app.textFields["Tap to answer"].exists)
69+
try app.textFields["Tap to answer"].enter(value: "leland@stanford.edu")
70+
6471
XCTAssert(nextButton.isEnabled)
6572
nextButton.tap()
6673

0 commit comments

Comments
 (0)