Duplicate Mod Scripts Causing Errors

[valkyrienyanko]

Description

When creating duplicate mods with identical script names, errors occur during runtime. This issue affects both C# and GDScript mods.

Steps to Reproduce

1. Duplicate the res://Mods/Example Mod directory to res://Mods/Example Mod 2.
2. Modify the id in the mod.json of the new mod from example_mod to example_mod_2.
3. Run the game.

Expected Behavior

Both mods should load and execute without errors, printing unique greetings.

Actual Behavior

C# Mods

• First Kind of Error:

  An item with the same key has already been added. Key: res://valkyrienyanko/example_mod/Mod.cs
  

  • Points to: ModLoader.cs#L74

• Second Kind of Error:

  Assembly with same name is already loaded
  

  • Points to: ModLoader.cs#L73

GDScript Mods

• Console Output:

  Loading C:/Users/VALK-DESKTOP/Documents/_Godot Projects/Template/GodotProject/Mods/Example Mod/mod.pck for example_mod
  Loading C:/Users/VALK-DESKTOP/Documents/_Godot Projects/Template/GodotProject/Mods/example_mod_2/mod.pck for example_mod_2
  Hello from Mod 1
  Hello from Mod 1
  

  • Expected: Hello from Mod 1 and Hello from Mod 2
  • Actual: Hello from Mod 1 printed twice

Observations

• C# scripts with the same name in different mods cause errors.
• GDScript mods with the same script names also exhibit unexpected behavior.

Proposed Solutions

1. Switch to GDScript for Mods:

   • If GDScript does not have the same naming conflict issues, consider using GDScript for modding.

2. Refactor C# Mod Loading:

   • Modify the mod loading logic to search for the first DLL file in the mod folder and load it. This might resolve DLL naming conflicts.

Additional Notes

• Changing DLL names did not resolve the issue.
• Test files provided:
  • Example Mod.zip
  • example_mod_2.zip

Relevant Issues

• Godot 4 .Net - Loading / Assigning a script exported from another project fails with error ("Cannot instance script because the associated class could not be found") godotengine/godot#75352

Conclusion

The current mod loading mechanism needs to be revised to handle duplicate script names across different mods effectively. Switching to GDScript or refactoring the C# mod loading process are potential solutions to address this issue.