`FieldVectorStyle` potentially relies on a bug in `Base.AbstractArrayStyle` promotion rule

[adienes]

revealed during a PkgEval run on JuliaLang/julia#35948, which contained errors like this

  MethodError: no method matching ClimaCore.Fields.FieldVectorStyle(::Val{1})
  The type `ClimaCore.Fields.FieldVectorStyle` exists, but no method is defined for this combination of argument types when trying to construct it.
  Closest candidates are:
    ClimaCore.Fields.FieldVectorStyle()
     @ ClimaCore ~/.julia/packages/ClimaCore/u7CJw/src/Fields/fieldvector.jl:149
  Stacktrace:
    [1] Base.Broadcast.BroadcastStyle(::Base.Broadcast.DefaultArrayStyle{0}, ::ClimaCore.Fields.FieldVectorStyle)
      @ Base.Broadcast ./broadcast.jl:141
    [2] result_style(s1::Base.Broadcast.DefaultArrayStyle{0}, s2::ClimaCore.Fields.FieldVectorStyle)
      @ Base.Broadcast ./broadcast.jl:465
    [3] combine_styles(c1::Float64, c2::ClimaCore.Fields.FieldVector{Float64, @NamedTuple{my_var::ClimaCore.Fields.Field{ClimaCore.DataLayouts.VF{Float64, 10, Matrix{Float64}}, 

potential errors in the definition of FieldVectorStyle here https://github.com/search?q=repo%3ACliMA%2FClimaCore.jl%20FieldVectorStyle&type=code could have been exposed by the bugfix

[adienes]

I think it could be fixed by adding definitions like these

FieldVectorStyle(::Val{0}) = FieldVectorStyle()
FieldVectorStyle(::Val{1}) = FieldVectorStyle()
FieldVectorStyle(::Val{N}) where N = Base.Broadcast.DefaultArrayStyle{N}()

(or customized to however you want it to broadcast)

see the note about ::Val constructors in the API docs here: https://docs.julialang.org/en/v1/manual/interfaces/#writing-binary-broadcasting-rules

[charleskawczynski]

Closed by #2333.