Skip to content

PhpBrowser _closeSession doesn't close session. #9

Open
@Naktibalda

Description

@Naktibalda

https://github.com/Codeception/Codeception/blob/2.2.2/src/Codeception/Module/PhpBrowser.php#L279

    public function _closeSession($session)
    {
        unset($session);
    }

All _closeSession does is unsetting a local variable.
To achieve desired effect, $session would have to be passed by reference and value overwritten instead of unsetting.

The only place where this method is called is https://github.com/Codeception/Codeception/blob/2.2.2/src/Codeception/Lib/Friend.php#L70

Update: _backupSession is fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions