Skip to content

Commit 03af8d4

Browse files
authored
Fix PHP 8.4 deprecation warnings (#109)
1 parent 108b200 commit 03af8d4

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Diff for: .github/workflows/main.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ jobs:
88

99
strategy:
1010
matrix:
11-
php: [8.0, 8.1, 8.2]
11+
php: [8.0, 8.1, 8.2, 8.3, 8.4]
1212

1313
steps:
1414
- name: Checkout code
15-
uses: actions/checkout@v3
15+
uses: actions/checkout@v4
1616

1717
- name: Setup PHP
1818
uses: shivammathur/setup-php@v2

Diff for: src/Codeception/Lib/Connector/Yii2.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ public function getCsrfParamName(): string
250250
return $this->getApplication()->request->csrfParam;
251251
}
252252

253-
public function startApp(\yii\log\Logger $logger = null): void
253+
public function startApp(?\yii\log\Logger $logger = null): void
254254
{
255255
codecept_debug('Starting application');
256256
$config = require($this->configFile);

Diff for: src/Codeception/Module/Yii2.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -723,11 +723,11 @@ public function grabComponent(string $component): null|object
723723
* $I->seeEmailIsSent(3);
724724
* ```
725725
*
726-
* @param int $num
726+
* @param int|null $num
727727
* @throws \Codeception\Exception\ModuleException
728728
* @part email
729729
*/
730-
public function seeEmailIsSent(int $num = null): void
730+
public function seeEmailIsSent(?int $num = null): void
731731
{
732732
if ($num === null) {
733733
$this->assertNotEmpty($this->grabSentEmails(), 'emails were sent');

0 commit comments

Comments
 (0)