Crash on startup plugin failure.

[rustyrussell]

Issue and Steps to Reproduce

Already in transaction from lightningd/io_loop_with_timers.c:31
lightningd: FATAL SIGNAL 6 (version v0.9.1-303-g9b0af9f)
0x182a25 send_backtrace
	common/daemon.c:38
0x182acb crashdump
	common/daemon.c:51
0x5bd7fcf ???
	???:0
0x5bd7f47 ???
	???:0
0x5bd98b0 ???
	???:0
0x135637 fatal
	lightningd/log.c:787
0x1652d6 db_begin_transaction_
	wallet/db.c:859
0x15b5e2 plugin_hook_callback
	lightningd/plugin_hook.c:214
0x15b350 plugin_hook_killed
	lightningd/plugin_hook.c:142
0x1e69ee notify
	ccan/ccan/tal/tal.c:240
0x1e6edd del_tree
	ccan/ccan/tal/tal.c:402
0x1e6f2f del_tree
	ccan/ccan/tal/tal.c:412
0x1e7269 tal_free
	ccan/ccan/tal/tal.c:486
0x1560ec plugin_kill
	lightningd/plugin.c:278
0x158796 plugin_manifest_timeout
	lightningd/plugin.c:1141
0x1997fa timer_expired
	common/timeout.c:39
0x12d3ba io_loop_with_timers
	lightningd/io_loop_with_timers.c:32
0x132c20 main
	lightningd/lightningd.c:1016
0x5bbab96 ???
	???:0
0x115bc9 ???
	???:0
0xffffffffffffffff ???
	???:0
Log dumped in crash.log.20201110000108
pay: Lost connection to the RPC socket.
autoclean: Lost connection to the RPC socket.
spenderp: Lost connection to the RPC socket.txprepare: Lost connection to the RPC socket.keysend: Lost connection to the RPC socket.

getinfo output

[rustyrussell]

Actually, this only happens if hook is being called while it times out init (we call hooks before init returns, yeah...). It seems it's always been there, but not worth holding up release for.

[ZmnSCPxj]

This was triggered by the clboss bug... sorry.