ccan: fix compilation error about const types #6950
Conversation
This commit fixes the following build error ccan/ccan/fdpass/fdpass.c:16:8: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] char buf[CMSG_SPACE(sizeof(fd))]; This is strange from a UNIX proxpective because the macros return a size_t and the size_t is a unsigned integer type that should be compatible with the array declaration. But for some plaform/or compiler this looks like not true? Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
I'd be truly surprised if moving preprocessor instructions around actually addresses a compilation error. As such I'd like to have confirmation that this addresses the issue at hand. If this truly is a fix to the problem, then the patch also belongs upstreamed into |
Yeah, I am not able to take my mental model back, I forget why this could work. However, I am not able to work blinded so I just put this there and wait for a user that can help to track it down
Yep! |
|
Mh I was wrong, and @cdecker you are right my code is just another way to write the same things, looks like this is a GCC bug on osx? |
This commit fixes the following build error
ccan/ccan/fdpass/fdpass.c:16:8: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] char buf[CMSG_SPACE(sizeof(fd))];
This is strange from a UNIX perspective because the macros return a size_t and the size_t is an unsigned integer type that should be compatible with the array declaration.
But for some plaform/or compilers this looks like not true?
Maybe Fixes #6910