Skip to content

Commit 48bdd23

Browse files
committed
Refactor test code helper method
1 parent 58445b2 commit 48bdd23

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

src/board/board.service.spec.ts

+14
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,20 @@ describe('BoardService Logic test', () => {
5353
});
5454
};
5555

56+
const saveBoards = async (count: number): Promise<User> => {
57+
const savedUser = await saveUser();
58+
for (let i = 0; i < count; i++) {
59+
const board = new Board();
60+
board.setContent = `${CONTENT + count}`;
61+
board.setTitle = `${TITLE + count}`;
62+
board.user = savedUser;
63+
await boardRepository.save(board);
64+
}
65+
return userRepository.findOne(savedUser.getUser_id, {
66+
relations: ['boards'],
67+
});
68+
};
69+
5670
beforeAll(async () => {
5771
connection = await createMemoryDB([User, Board]);
5872
userRepository = await connection.getRepository(User);

test/board.e2e-spec.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ describe('BoardController (e2e)', () => {
2626
return await userRepository.save(savedUser);
2727
};
2828

29-
const saveBoard = async (count: number): Promise<User> => {
29+
const saveBoards = async (count: number): Promise<User> => {
3030
const savedUser = await saveUser();
3131
for (let i = 0; i < count; i++) {
3232
const board = new Board();
33-
board.setContent = CONTENT;
34-
board.setTitle = TITLE;
33+
board.setContent = `${CONTENT + count}`;
34+
board.setTitle = `${TITLE + count}`;
3535
board.user = savedUser;
3636
await boardRepository.save(board);
3737
}
@@ -77,7 +77,7 @@ describe('BoardController (e2e)', () => {
7777
});
7878

7979
it('[GET] /board/{boardId} : Response is OK if conditions are right', async () => {
80-
const savedUser = await saveBoard(1);
80+
const savedUser = await saveBoards(1);
8181
const boardId = savedUser.boards[0].getBoard_id;
8282

8383
const result = await request(app.getHttpServer())
@@ -87,8 +87,8 @@ describe('BoardController (e2e)', () => {
8787
expect(response.name).toBe(NAME);
8888
expect(response.userId).toBe(savedUser.getUser_id);
8989
expect(response.boardId).toBe(boardId);
90-
expect(response.content).toBe(CONTENT);
91-
expect(response.title).toBe(TITLE);
90+
expect(response.content).toBe(`${CONTENT + 1}`);
91+
expect(response.title).toBe(`${TITLE + 1}`);
9292
});
9393

9494
it('[GET] /board/{boardId} : Response is NOT_FOUND if boardId is invalid', async () => {

0 commit comments

Comments
 (0)