Merge pull request #26 from GoogleWebComponents/fix-firebase-collection-child-changed

Fixes Firebase Collection child changed

Author: cdata

firebase-collection.html

@@ -268,6 +268,20 @@ <h4>[[dinosaur.__firebaseKey__]]</h4>
       this.query.ref().child(key).remove();
     },
 
+    _applyLocalDataChanges: function(change) {
+      var pathParts = change.path.split('.');
+      var index;
+      var value;
+
+      if (pathParts.length < 2 || pathParts[1] === 'splices') {
+        return;
+      }
+
+      index = parseInt(pathParts[1], 10);
+      value = this.data[index];
+      this.query.ref().child(value.__firebaseKey__).set(value);
+    },
+
     _computeQuery: function(location, limitToFirst, limitToLast, orderByMethodName, startAt, endAt, equalTo) {
       var query;
 
@@ -431,7 +445,7 @@ <h4>[[dinosaur.__firebaseKey__]]</h4>
 
         this._valueMap[oldValue.__firebaseKey__] = null;
         this._valueMap[value.__firebaseKey__] = value;
-        this.splice('data' + this.data.indexOf(oldValue), 1, value);
+        this.splice('data', this.data.indexOf(oldValue), 1, value);
       });
     },
 

test/firebase-collection.html

@@ -40,6 +40,15 @@
       </firebase-collection>
     </template>
   </test-fixture>
+  <test-fixture id="ChangingChildren">
+    <template>
+      <firebase-collection
+        location="https://fb-element-demo.firebaseio.com/test/changing_children"
+        order-by-child="foo"
+        log>
+      </firebase-collection>
+    </template>
+  </test-fixture>
 
   <test-fixture id="SyncingCollections">
     <template>
@@ -148,6 +157,55 @@
         });
       });
 
+      suite('a child changes', function() {
+        setup(function(done) {
+          firebase = fixture('ChangingChildren');
+          waitForEvent(firebase, 'firebase-value').then(function() {
+            done();
+          }).catch(function(e) {
+            done(e)
+          });
+        });
+
+        test('updates the child key in place with the new value', function(done) {
+          var childrenKeys = [];
+
+          waitForEvent(firebase, 'firebase-value').then(function() {
+            var middleValue = firebase.getByKey(childrenKeys[1]);
+            var changes;
+
+            expect(middleValue.foo).to.be.equal(1);
+            expect(middleValue.bar).to.be.equal(1);
+
+            changes = waitForEvent(firebase, 'firebase-child-changed');
+
+            firebase.set('data.' + firebase.data.indexOf(middleValue) + '.bar', 2);
+
+            return changes;
+          }).then(function() {
+            var middleValue = firebase.getByKey(childrenKeys[1]);
+
+            expect(middleValue.foo).to.be.equal(1);
+            expect(middleValue.bar).to.be.equal(2);
+
+            done();
+          }).catch(function(e) {
+            done(e);
+          }).then(function() {
+            childrenKeys.forEach(function(key) {
+              firebase.removeByKey(key);
+            });
+          });
+
+          childrenKeys = [0, 1, 2].map(function(value, index) {
+            return firebase.add({
+              foo: value,
+              bar: index
+            }).key();
+          });
+        });
+      });
+
       suite('syncing collections', function() {
         var localFirebase;
         var remoteFirebase;