Skip to content

Commit 97e6afa

Browse files
committed
update docs + clean up
1 parent 3513885 commit 97e6afa

File tree

3 files changed

+15
-44
lines changed

3 files changed

+15
-44
lines changed

.github/workflows/commit-review-cleanup.yml

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
name: Commit Review Cleanup
22

3+
# TODO: does not get trigger for some reason
34
on:
45
pull_request_review:
56
types: [submitted]

.github/workflows/commit-review.yml

+1-43
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,6 @@ env:
99
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1010

1111
jobs:
12-
# parse:
13-
# runs-on: ubuntu-latest
14-
# env:
15-
# REVIEWERS_FILE: reviewers.json
16-
# outputs:
17-
# reviewersJSON: ${{ steps.parse_reviewers.outputs.reviewersJSON }}
18-
# steps:
19-
# - uses: actions/checkout@v3
20-
21-
# # https://stackoverflow.com/questions/61919141/read-json-file-in-github-actions
22-
# - name: Parse Reviewers
23-
# id: parse_reviewers
24-
# run: |
25-
# content=`cat ${{ env.REVIEWERS_FILE }}`
26-
# # the following lines are only required for multi line json
27-
# content="${content//'%'/'%25'}"
28-
# content="${content//$'\n'/'%0A'}"
29-
# content="${content//$'\r'/'%0D'}"
30-
# # end of optional handling for multi line json
31-
# echo "::set-output name=reviewersJSON::$content"
32-
3312
check:
3413
runs-on: ubuntu-latest
3514
strategy:
@@ -123,25 +102,4 @@ jobs:
123102
--reviewer "$REVIEWER" \
124103
--base "$BASE_BRANCH" \
125104
--head "$TARGET_BRANCH"
126-
done
127-
128-
# emails:
129-
# runs-on: ubuntu-latest
130-
# needs: check
131-
# strategy:
132-
# matrix:
133-
# reviewer: ${{ fromJSON(needs.check.outputs.missingReviewers) }}
134-
# steps:
135-
# - name: Send email
136-
# uses: dawidd6/action-send-mail@v3
137-
# env:
138-
# KEYWORD: $(echo ${{ matrix.reviewer }} | sed 's/:/ /g')
139-
# with:
140-
# server_address: smtp.gmail.com
141-
# server_port: 465
142-
# username: ${{ secrets.MAIL_USER }}
143-
# password: ${{ secrets.MAIL_PASSWORD }}
144-
# from: ${{ secrets.MAIL_USER }}
145-
# subject: "Test"
146-
# to: min.yin@it-experts.at
147-
# body: ${{ env.KEYWORD }}
105+
done

README.md

+13-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
1-
Run locally using [act](https://github.com/nektos/act)
1+
## Testing
2+
3+
Run locally using [act](https://github.com/nektos/act).
4+
Some commands might not be found like `gh` depending on the container you use
25

36
```
47
act -e push.json
58
```
9+
10+
## Info
11+
12+
Every commit to the `main` branch will be checked on keyword changes and if the mandatory reviewers have approved it.
13+
They are defined in the [commit-review.yml](./.github.com/workflows/commit-review.yml).
14+
The reviewers are assigned using their github usernames.
15+
16+
The workflow will create a PR for that change and assign the reviewers.
17+
If the changes were merged with a PR then only the missing mandatory reviewers will be added.

0 commit comments

Comments
 (0)