Skip to content

Commit 77ca0d4

Browse files
kholood-eamzelzoghbi
authored andcommitted
fix(android): APM network logging(#1253)
* fix(android): add W3C External Trace Attributes placeholder * chore: add CHANGLOG * chore: add CHANGLOG * fix: remove ios sub module
1 parent e2cd1d6 commit 77ca0d4

File tree

2 files changed

+23
-20
lines changed

2 files changed

+23
-20
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Fixed
66

7+
- Fix APM network logging on Android ([#1253](https://github.com/Instabug/Instabug-React-Native/pull/1253)).
78
- Fix an OOM (out-of-memory) crash while saving network logs on Android ([#1244](https://github.com/Instabug/Instabug-React-Native/pull/1244)).
89

910
## [13.2.0](https://github.com/Instabug/Instabug-React-Native/compare/v13.1.1...v13.2.0) (July 7, 2024)

android/src/main/java/com/instabug/reactlibrary/RNInstabugAPMModule.java

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import com.instabug.apm.APM;
1515
import com.instabug.apm.model.ExecutionTrace;
1616
import com.instabug.apm.networking.APMNetworkLogger;
17+
import com.instabug.apm.networkinterception.cp.APMCPNetworkLog;
1718
import com.instabug.reactlibrary.utils.MainThreadHandler;
1819

1920
import org.json.JSONException;
@@ -338,27 +339,28 @@ private void networkLogAndroid(final double requestStartTime,
338339
final String errorMessage = hasError ? errorDomain : null;
339340

340341
try {
341-
Method method = getMethod(Class.forName("com.instabug.apm.networking.APMNetworkLogger"), "log", long.class, long.class, String.class, String.class, long.class, String.class, String.class, String.class, String.class, String.class, long.class, int.class, String.class, String.class, String.class, String.class);
342+
Method method = getMethod(Class.forName("com.instabug.apm.networking.APMNetworkLogger"), "log", long.class, long.class, String.class, String.class, long.class, String.class, String.class, String.class, String.class, String.class, long.class, int.class, String.class, String.class, String.class, String.class, APMCPNetworkLog.W3CExternalTraceAttributes.class);
342343
if (method != null) {
343-
method.invoke(
344-
networkLogger,
345-
requestStartTime,
346-
requestDuration,
347-
requestHeaders,
348-
requestBody,
349-
requestBodySize,
350-
requestMethod,
351-
requestUrl,
352-
requestContentType,
353-
responseHeaders,
354-
responseBody,
355-
responseBodySize,
356-
statusCode,
357-
responseContentType,
358-
errorMessage,
359-
gqlQueryName,
360-
serverErrorMessage
361-
);
344+
method.invoke(
345+
networkLogger,
346+
(long) requestStartTime,
347+
(long) requestDuration,
348+
requestHeaders,
349+
requestBody,
350+
(long) requestBodySize,
351+
requestMethod,
352+
requestUrl,
353+
requestContentType,
354+
responseHeaders,
355+
responseBody,
356+
(long)responseBodySize,
357+
(int) statusCode,
358+
responseContentType,
359+
errorMessage,
360+
gqlQueryName,
361+
serverErrorMessage,
362+
null
363+
);
362364
} else {
363365
Log.e("IB-CP-Bridge", "APMNetworkLogger.log was not found by reflection");
364366
}

0 commit comments

Comments
 (0)