Skip to content

Commit 9b2799e

Browse files
authored
Merge pull request #66 from JuliaLogging/ox/override_should_level_check
Don't recheck the level in OverrideLogger's shouldlog
2 parents 782c1ef + 090453c commit 9b2799e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/overridelogger.jl

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ handle_message(logger::LevelOverrideLogger, args...; kwargs...) =
1515
handle_message(logger.logger, args...; kwargs...)
1616

1717
function shouldlog(logger::LevelOverrideLogger, level, args...)
18-
# Ignore the logger.logger's own level and instead check the override level
19-
level >= logger.level && shouldlog(logger.logger, level, args...)
18+
# unlike other CompositionalLoggers: No level check as we are ignoring the
19+
# logger.loggers level and just using the overriden leven which has already been checked
20+
return shouldlog(logger.logger, level, args...)
2021
end
2122

2223
min_enabled_level(logger::LevelOverrideLogger) = logger.level

0 commit comments

Comments
 (0)