make convert script configurable with ENV-variables for docker run

Author: LoveBootCaptain

Dockerfile

@@ -9,6 +9,17 @@ ENV DEBIAN_FRONTEND noninteractive
 ENV HOME /root
 ENV PATH /root/scripts:$PATH
 
+ENV AUDIO_ENCODER aac
+ENV AUDIO_BITRATE 192
+
+ENV VIDEO_ENCODER x264
+ENV VIDEO_FORMAT mp4
+
+ENV CODEC_PRESET veryfast
+ENV CODEC_QUALITY 23
+
+ENV SOURCE_EXT mkv
+
 # set and update repo
 RUN sed -i 's#http://archive.ubuntu.com/#http://tw.archive.ubuntu.com/#' /etc/apt/sources.list \
     && apt-get update
@@ -30,8 +41,9 @@ RUN apt-get install -y --no-install-recommends \
     python3-setuptools \
     build-essential
 
-# install video apps
+# install other apps
 RUN apt-get install -y \
+	nano \
 	handbrake-cli \
 	mkvtoolnix \
 	gpac

README.md

@@ -19,17 +19,23 @@ docker build --build-arg SETLANG=de_DE.UTF-8 -t lovebootcaptain/handbrakecli-pyt
 ## Run
 ```bash
 docker run
---entrypoint bash
--v /Volumes/video:/root/input
--v /Volumes/video/transcoded:/root/output
---env SETLANG=de_DE.UTF-8
---env LC_ALL=de_DE.UTF-8
---env LANG=de_DE.UTF-8
---env LANGUAGE=de_DE:de
---env TZ=Europe/Berlin
---name handbrakecli-python3
--h docker-handbrake
-lovebootcaptain/handbrakecli-python3:latest
+    --entrypoint bash
+    -v /Volumes/video:/root/input
+    -v /Volumes/video/transcoded:/root/output
+    --env LC_ALL=de_DE.UTF-8
+    --env LANG=de_DE.UTF-8
+    --env LANGUAGE=de_DE:de
+    --env TZ=Europe/Berlin
+    --env VIDEO_FORMAT=mp4
+    --env SOURCE_EXT=mkv
+    --env AUDIO_ENCODER=aac
+    --env AUDIO_BITRATE=192
+    --env VIDEO_ENCODER=x264
+    --env CODEC_PRESET=veryfast
+    --env CODEC_QUALITY=23
+    --name handbrakecli-python3
+    -h docker-handbrake
+lovebootcaptain/handbrakecli-python3:latest 
 ```
 ## Usage of included scripts
 
@@ -52,6 +58,6 @@ feel free to add and/or **contribute** your own.
 
 ### TODO
 
-- add a watchdog for a folder with python3
-- make watchdog configurable with ENV-variables for `docker run`
-- make `convert` script configurable with ENV-variables for `docker run`
+- [ ] add a watchdog for a folder with python3
+- [ ] make watchdog configurable with ENV-variables for `docker run`
+- [x] make `convert` script configurable with ENV-variables for `docker run`

scripts/LoopConverter

@@ -1,27 +1,23 @@
 #!/bin/sh
 
-EXT=$1
+EXT=${SOURCE_EXT}
 
-if [ $# -eq 0 ]
-  then
-    echo "No arguments supplied"
-    echo "usage:    LoopConverter [file extension to convert]"
-    echo "e.g.:     LoopConverter mkv /path/to/your/folder"
+echo "transcoding all $SOURCE_EXT files to $VIDEO_FORMAT"
 
-    else
-        for i in *
-            do
-                if [ "${i}" != "${i%.${EXT}}" ];then
+for i in *
+    do
+        if [ "${i}" != "${i%.${EXT}}" ]
+            then
                 echo "convertible file found: $i"
-            fi
-        done
+        fi
+done
 
-        for i in *
-            do
-                if [ "${i}" != "${i%.${EXT}}" ];then
-                    echo "converting file $i"
-                    convert "$i"
-                fi
-        done
-fi
+for i in *
+    do
+        if [ "${i}" != "${i%.${EXT}}" ]
+            then
+                echo "converting file $i"
+                convert "$i"
+        fi
+done
 

scripts/convert

@@ -1,5 +1,6 @@
 #!/bin/sh
 
+
 NOW=$(date +"%m%d%Y")
 PGMNAME=/usr/bin/HandBrakeCLI
 
@@ -18,10 +19,21 @@ BASEPATH=$(dirname "$1")
 BASEFILE=$(basename "$1")
 FILENAME="${BASEFILE%%.*}"
 
-echo "Starting $NOW"
-${PGMNAME} --input "$1" --format mkv --aencoder aac --ab 192 --encoder x264 --x264-preset veryfast --quality 23 --turbo --encoder-level 4.1 --output "$BASEPATH/$FILENAME.mkv"
+echo "Starting $NOW with VIDEO_FORMAT: $VIDEO_FORMAT AUDIO_ENCODER: $AUDIO_ENCODER AUDIO_BITRATE: $AUDIO_BITRATE VIDEO_ENCODER: $VIDEO_ENCODER CODEC_PRESET: $CODEC_PRESET CODEC_QUALITY: $CODEC_QUALITY"
+
+${PGMNAME} --input "$1" \
+    --format ${VIDEO_FORMAT} \
+    --aencoder ${AUDIO_ENCODER} \
+    --ab ${AUDIO_BITRATE} \
+    --encoder ${VIDEO_ENCODER} \
+    --x264-preset ${CODEC_PRESET} \
+    --quality ${CODEC_QUALITY} \
+    --turbo --encoder-level 4.1 \
+    --output "$BASEPATH/$FILENAME.${VIDEO_FORMAT}"
+
+
 check_errs $? "Failed to convert file $1"
 
-echo "Removing original file."
-rm -f "$1"
-check_errs $? "Failed to remove original file $1"
+# echo "Removing original file."
+# rm -f "$1"
+# check_errs $? "Failed to remove original file $1"