From 6a73787c1f0ff240aa0be52e46d50724f9b68508 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 3 Nov 2022 21:06:04 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- dataloader.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/dataloader.py b/dataloader.py index 20383ba..1ecfddb 100644 --- a/dataloader.py +++ b/dataloader.py @@ -44,7 +44,26 @@ def _recall_func(num,block_size,total_size): print('Successfully download.',filename,file_info.st_size,'bytes') print('Extracting files...') with tarfile.open(fname) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) os.remove(fname) return process_cifar()