From 194f2b839e1385d7c97929b6037fd928c61f18c6 Mon Sep 17 00:00:00 2001 From: Elliot Winkler Date: Tue, 29 Apr 2025 12:54:46 -0600 Subject: [PATCH] remote-feature-flag-controller: Fix flaky test The test for `generateDeterministicRandomNumber` sometimes fails because it relies on the behavior of `uuidv4`, which is non-deterministic, and needs to be more lenient in the range of acceptable return values. --- .../src/utils/user-segmentation-utils.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.test.ts b/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.test.ts index f523b732d6a..43bcb8cecca 100644 --- a/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.test.ts +++ b/packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.test.ts @@ -130,9 +130,9 @@ describe('user-segmentation-utils', () => { distribution[Math.min(distributionIndex, 9)] += 1; }); - // Each range should have roughly 10% of the values and 30% deviation + // Each range should have roughly 10% of the values and 40% deviation const expectedPerRange = samples / ranges.length; - const allowedDeviation = expectedPerRange * 0.3; + const allowedDeviation = expectedPerRange * 0.4; // Check distribution distribution.forEach((count) => {