Roll back 'Hidden' diagnostic suppression

Author: nickspoons

python/omnisharp/util.py

@@ -137,14 +137,9 @@ def quickfixes_from_response(ctx, response):
             'vcol': 0
         }
         if 'LogLevel' in quickfix:
-            if quickfix['LogLevel'] == 'Error':
-                item['type'] = 'E'
-            elif quickfix['LogLevel'] == 'Warning':
-                item['type'] = 'W'
-            elif quickfix['LogLevel'] == 'Info':
-                item['type'] = 'I'
-            else:
-                continue
+            item['type'] = 'E' if quickfix['LogLevel'] == 'Error' else 'W'
+            if quickfix['LogLevel'] == 'Hidden':
+                item['subtype'] = 'Style'
 
         items.append(item)
 

python/tests/test_util.py

@@ -180,25 +180,13 @@ def test_quickfixes_from_response(ctx):
     ]
     assert qf == expected
 
-    response = [
-        {
-            'Text': 'some text',
-            'Line': 5,
-            'Column': 8,
-            'LogLevel': 'Hidden',
-        },
-    ]
-    qf = quickfixes_from_response(ctx, response)
-    expected = []
-    assert qf == expected
-
     response = [
         {
             'FileName': 'foo.cs',
             'Text': 'some text',
             'Line': 5,
             'Column': 8,
-            'LogLevel': 'Warning',
+            'LogLevel': 'Hidden',
         },
     ]
     qf = quickfixes_from_response(ctx, response)
@@ -210,28 +198,7 @@ def test_quickfixes_from_response(ctx):
             'col': 8,
             'vcol': 0,
             'type': 'W',
-        },
-    ]
-    assert qf == expected
-
-    response = [
-        {
-            'FileName': 'foo.cs',
-            'Text': 'some text',
-            'Line': 5,
-            'Column': 8,
-            'LogLevel': 'Info',
-        },
-    ]
-    qf = quickfixes_from_response(ctx, response)
-    expected = [
-        {
-            'filename': 'foo.cs',
-            'text': 'some text',
-            'lnum': 5,
-            'col': 8,
-            'vcol': 0,
-            'type': 'I',
+            'subtype': 'Style',
         },
     ]
     assert qf == expected