Function double execution

[ShaneBeee]

Skript/Server Version

[12:56:46 INFO]: [Skript] Server Version: 1.21.4-DEV-02dfa94 (MC: 1.21.4)
[12:56:46 INFO]: [Skript] Skript Version: 2.10.2 (skriptlang-github)
[12:56:46 INFO]: [Skript] Installed Skript Addons: None
[12:56:46 INFO]: [Skript] Installed dependencies: None

Bug Description

This was brought to my attention by @OfficialDonut so I'm just relaying the issue.

When broadcasting a stringified function, its called twice.

Test code:

function test(num: number) :: number:
	broadcast "Executing"
	return {_num}

on load:
	broadcast "%test(1)%"

Console output:

[12:54:40 INFO]: Executing
[12:54:40 INFO]: Executing
[12:54:40 INFO]: 1

this does not appear to happen when stringifying and using send it also does not appear to happen when broadcasting without stringify.

Expected Behavior

The function should only be called once.

Steps to Reproduce

See code above

Errors or Screenshots

No response

Other

No response

Agreement

• I have read the guidelines above and affirm I am following them with this report.

[sovdeeth]

very odd; i can replicate

[ShaneBeee]

very odd; i can replicate

Yeah this one got me, Donut showed 3 different uses cases, and ONLY stringified broadcast did this.
That just made no sense to me.

[sovdeeth]

It evaluates once to check dispatch event, then a second time to actually construct the components.

[ShaneBeee]

Ahh ok. I stared at that for a few minutes last night (It was late, I was tired), that didn't poke out to me.

[sovdeeth]

Seems like a bit of a tricky problem. The best solution that comes to mind is a new method that provides both the string and component together via a single evaluation.

[sovdeeth]

@ShaneBeee or @OfficialDonut can you verify that the above PR fixes the issue?

[OfficialDonut]

@ShaneBeee or @OfficialDonut can you verify that the above PR fixes the issue?

yep that fixed it