Virtual worldborder shared between players due to improper initialization

[ahmadmsaleem]

Skript/Server Version

[17:11:19 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[17:11:19 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[17:11:19 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[17:11:19 INFO]: [Skript] Server Version: 1.21.1-132-b48403b (MC: 1.21.1)
[17:11:19 INFO]: [Skript] Skript Version: 2.11.0 (skriptlang-github)
[17:11:19 INFO]: [Skript] Installed Skript Addons: 
[17:11:19 INFO]: [Skript]  - skript-placeholders v1.7.0 (https://github.com/APickledWalrus/skript-placeholders)
[17:11:19 INFO]: [Skript]  - SkBee v3.11.1 (https://github.com/ShaneBeee/SkBee)
[17:11:19 INFO]: [Skript]  - skript-reflect v2.6 (https://github.com/SkriptLang/skript-reflect)
[17:11:19 INFO]: [Skript] Installed dependencies: 
[17:11:19 INFO]: [Skript]  - Vault v1.7.3-b131
[17:11:19 INFO]: [Skript]  - WorldGuard v7.0.12+829a4a4

Bug Description

When using a function like setPersonalBorder(p: player, radius: number = 3), all players share the same virtual worldborder instance. This seems to happen because the border is initialized in a way that causes it to be reused for every player.

function setPersonalBorder(p: player, radius: number = 3):
	set {_center} to location of {_p}
	set {_border} to a virtual worldborder:
		set worldborder radius to {_radius}
		set world border center of event-worldborder to {_center}
	set worldborder of {_p} to {_border}

Expected Behavior

Each player should have their own unique worldborder, centered around their location.

Steps to Reproduce

use function above

Errors or Screenshots

No response

Other

No response

Agreement

• I have read the guidelines above and affirm I am following them with this report.

[Fusezion]

I'm a bit confused on how it would occur, as looking over the code it's defined in init (kind of weird ngl) but it uses Bukkit.createWorldBorder() So unless skript is magically only calling init once it shouldn't occur

[sovdeeth]

I'm a bit confused on how it would occur, as looking over the code it's defined in init (kind of weird ngl) but it uses Bukkit.createWorldBorder() So unless skript is magically only calling init once it shouldn't occur

Correct, init is only called once per usage of the syntax. So that one create worldborder section will always return the same worldborder.

[ahmadmsaleem]

phill find a fix !

[Fusezion]

phill find a fix !

the fix would be to move it into the the get call rather than init

I'm a bit confused on how it would occur, as looking over the code it's defined in init (kind of weird ngl) but it uses Bukkit.createWorldBorder() So unless skript is magically only calling init once it shouldn't occur

Correct, init is only called once per usage of the syntax. So that one create worldborder section will always return the same worldborder.

Guessing the issue there then would be function call?

EDIT: nvm I'm an idiot and didn't think it only sets once during parse forget this