Skip to content

With caching, failure to open is only reported once when used with callbacks #1803

Open
@boimart1

Description

@boimart1

Issue Summary

When using the cached.Database function, and when providing a callback for error detection, multiple failed attempts to open the same database file will only call the first callback.

Attempting to open the database multiple times with listeners works as expected.

This problem manifests in the promise-based sqlite wrapper package, where attempting to open the same cached database multiple times will suspend subsequent promises indefinitely.

Steps to Reproduce

  1. Run the following snippet:
import sqlite3 from "sqlite3"

function openDbWithCallback(n) {
    sqlite3.cached.Database(
        'does_not_exist_cb.db',
        sqlite3.OPEN_READONLY,
        (err) => {
            if (err) {
                console.log(`open with callback #${n} failed: ${err}`);
            }
        });
}

openDbWithCallback(1);
openDbWithCallback(2);

function openDbWithListener(n) {
    const db = sqlite3.cached.Database('does_not_exist_listener.db', sqlite3.OPEN_READONLY)
    db.addListener('error', (err) => { console.log(`open with listener #${n} failed: ${err}`) })
}

openDbWithListener(1);
openDbWithListener(2);
  1. Observe that "open with callback" is only logged once, while "open with listener" is logged twice (as expected).

Version

5.1.7

Node.js Version

22.9.0

How did you install the library?

npm install with package.json on Windows 10 x64

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @boimart1

        Issue actions

          With caching, failure to open is only reported once when used with callbacks · Issue #1803 · TryGhost/node-sqlite3