Skip to content

Commit ddd5e69

Browse files
fix(logicbutton): defines border style
- border-style: solid removes the 3D effect on the button border - adds a note to the changeset
1 parent 20e7a92 commit ddd5e69

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.changeset/smart-spoons-sneeze.md

+5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"@spectrum-css/link": patch
66
"@spectrum-css/picker": patch
77
"@spectrum-css/floatingactionbutton": patch
8+
"@spectrum-css/logicbutton": patch
89
---
910

1011
### S2 button fixes
@@ -47,3 +48,7 @@ PRs used as reference:
4748
### S2 floating action button fix
4849

4950
Opts to use the color property as opposed to fill for the icon. This correctly passes the floating action button icon colors to the component, to override the fill property style that is set on the embedded `.spectrum-Icon`.
51+
52+
### S2 logic button fix
53+
54+
Adds `border-style: solid` to the styles to avoid a 3D effect on the border.

components/logicbutton/index.css

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
padding: var(--mod-logic-button-padding, var(--spectrum-component-edge-to-text-50));
4141

4242
border-width: var(--mod-logic-button-border-width, var(--spectrum-border-width-200));
43+
border-style: solid;
4344
border-radius: var(--mod-logic-button-border-radius, var(--spectrum-logic-button-border-radius));
4445

4546
font-size: var(--mod-logic-button-font-size, var(--spectrum-font-size-100));

0 commit comments

Comments
 (0)