Open
Description
Hi,
Firstly, thanks for this great Vim plugin.
Be curious regarding issue #31
Note: I personally never used extract method on static method.
Before
public static function testExtractMethodOnStatic($message)
{
// Make a very cool wave with the message
for ($i = 0; $i < strlen($message); $i++) {
$message[$i] = $i % 2 ? strtoupper($message[$i]) : strtolower($message[$i]);
}
}
After
public static function testExtractMethodOnStatic($message)
{
// Make a very cool wave with the message
$message = $this->makeWaveWithMessage($message);
}
private function makeWaveWithMessage($message)
{
for ($i = 0; $i < strlen($message); $i++) {
$message[$i] = $i % 2 ? strtoupper($message[$i]) : strtolower($message[$i]);
}
return $message;
}
Expected
public static function testExtractMethodOnStatic($message)
{
// Make a very cool wave with the message
$message = self::makeWaveWithMessage($message);
}
private static function makeWaveWithMessage($message)
{
for ($i = 0; $i < strlen($message); $i++) {
$message[$i] = $i % 2 ? strtoupper($message[$i]) : strtolower($message[$i]);
}
return $message;
}
Metadata
Metadata
Assignees
Labels
No labels