fixed typos

Author: bennobuilder

packages/core/tests/unit/runtime/subscription/sub.controller.test.ts

@@ -535,6 +535,13 @@ describe('SubController Tests', () => {
         );
         expect(callbackSubscriptionContainer.callback).toBe(dummyIntegration);
         expect(callbackSubscriptionContainer.ready).toBeTruthy();
+
+        // TODO find a way to spy on a class constructor without overwriting it
+        // https://stackoverflow.com/questions/48219267/how-to-spy-on-a-class-constructor-jest/48486214
+        // Because the below tests are not really related to this test,
+        // they are checking if the CallbackSubscriptionContainer got called with the right parameters
+        // by checking if CallbackSubscriptionContainer has set its properties correctly
+        // Note:This 'issue' happens in multiple parts of the AgileTs test
         expect(callbackSubscriptionContainer.key).toBe('randomKey');
         expect(callbackSubscriptionContainer.proxyKeyMap).toStrictEqual({});
         expect(callbackSubscriptionContainer.proxyBased).toBeFalsy();

packages/react/src/hocs/AgileHOC.ts

@@ -98,7 +98,7 @@ const createHOC = (
 
     constructor(props: any) {
       super(props);
-      this.agileInstance = (() => agileInstance) as any;
+      this.agileInstance = agileInstance;
       this.waitForMount = agileInstance.config.waitForMount;
     }
 
@@ -107,7 +107,7 @@ const createHOC = (
     // We could generate a id for each component but this would also happen in the constructor so idk
     // https://github.com/facebook/react/issues/12906
     UNSAFE_componentWillMount() {
-      // Create Subscription with Observer that have no Indicator and can't be merged into this.state (Rerender will be caused via force Update)
+      // Create Subscription with Observer that have no Indicator and can't be merged into 'this.state' (Rerender will be caused via force Update)
       if (depsWithoutIndicator.length > 0) {
         this.agileInstance.subController.subscribeWithSubsArray(
           this,
@@ -116,7 +116,7 @@ const createHOC = (
         );
       }
 
-      // Create Subscription with Observer that have an Indicator (Rerender will be cause via mutating this.state)
+      // Create Subscription with Observer that have an Indicator (Rerender will be cause via mutating 'this.state')
       if (depsWithIndicator) {
         const response = this.agileInstance.subController.subscribeWithSubsObject(
           this,
@@ -152,7 +152,7 @@ const createHOC = (
 //=========================================================================================================
 /**
  * @private
- * Extract Observers of dependencies which might not have an indicator.
+ * Extract Observers from dependencies which might not have an indicator.
  * If a indicator could be found it will be added to 'depsWithIndicator' otherwise to 'depsWithoutIndicator'.
  * @param deps - Dependencies to be formatted
  */
@@ -188,7 +188,7 @@ const formatDepsWithNoSafeIndicator = (
 //=========================================================================================================
 /**
  * @private
- * Extract Observers of dependencies which have an indicator through the object property key.
+ * Extract Observers from dependencies which have an indicator through the object property key.
  * @param deps - Dependencies to be formatted
  */
 const formatDepsWithIndicator = (deps: {

packages/vue/src/bindAgileInstances.ts

@@ -12,7 +12,7 @@ export function bindAgileInstances(
   deps: DepsType,
   agile: Agile,
   vueComponent: Vue
-) {
+): { [key: string]: any } {
   let depsWithoutIndicator: Array<Observer> = [];
   let depsWithIndicator: DepsWithIndicatorType;
 
@@ -25,7 +25,7 @@ export function bindAgileInstances(
     depsWithoutIndicator = response.depsWithoutIndicator;
   }
 
-  // Create Subscription with Observer that have no Indicator and can't be merged into the sharedState (Rerender will be caused via force Update)
+  // Create Subscription with Observer that have no Indicator and can't be merged into the 'sharedState' (Rerender will be caused via force Update)
   if (depsWithoutIndicator.length > 0) {
     agile.subController.subscribeWithSubsArray(
       vueComponent,
@@ -34,7 +34,7 @@ export function bindAgileInstances(
     );
   }
 
-  // Create Subscription with Observer that have an Indicator (Rerender will be cause via mutating this.$data.sharedState)
+  // Create Subscription with Observer that have an Indicator (Rerender will be cause via mutating 'this.$data.sharedState')
   if (depsWithIndicator) {
     return agile.subController.subscribeWithSubsObject(
       vueComponent,
@@ -51,7 +51,7 @@ export function bindAgileInstances(
 //=========================================================================================================
 /**
  * @private
- * Extract Observers of dependencies which might not have an indicator.
+ * Extract Observers from dependencies which might not have an indicator.
  * If a indicator could be found it will be added to 'depsWithIndicator' otherwise to 'depsWithoutIndicator'.
  * @param deps - Dependencies to be formatted
  */
@@ -87,7 +87,7 @@ const formatDepsWithNoSafeIndicator = (
 //=========================================================================================================
 /**
  * @private
- * Extract Observers of dependencies which have an indicator through the object property key.
+ * Extract Observers from dependencies which have an indicator through the object property key.
  * @param deps - Dependencies to be formatted
  */
 const formatDepsWithIndicator = (deps: {

packages/vue/src/vue.integration.ts

@@ -19,7 +19,7 @@ const vueIntegration = new Integration<typeof Vue, Vue>({
     // Update existing Data or if a new one got created set it via Vue
     // Note: Not merging 'updateData' into 'componentData'
     // because Vue tracks the local State changes via Proxy
-    // and by merging it, Vue couldn't detect the changes
+    // and by merging it, Vue can't detect the changes
     for (const key of Object.keys(updatedData)) {
       if (Object.prototype.hasOwnProperty.call(componentData, key)) {
         componentData.sharedState[key] = updatedData[key];
@@ -40,12 +40,13 @@ const vueIntegration = new Integration<typeof Vue, Vue>({
             this.$agile = agile;
           },
           methods: {
+            // TODO make 'bindAgileInstances' ('sharedState') more typesafe
             bindAgileInstances: function (
               deps: DepsType
             ): { sharedState: { [key: string]: any } } {
               return {
                 sharedState: {
-                  ...(this.$root.$data.sharedState || {}),
+                  ...(this?.$data?.sharedState || {}),
                   ...bindAgileInstances(deps, agile, this),
                 },
               };