include typings angular.d.ts

[PatrickJS]

Since Angular 2 uses TypeScript it would provide everyone with a better experience if Angular 1 provided the type definition files within the repo rather than typings

[aciccarello]

@alexeagle's blog post might be a helpful reference. I do wonder how hard it will be to keep the .d.ts file in sync with source releases without having to do many bug fix releases.

[alexeagle]

Since you don't import {} from 'angular' for angular1 usage, the typings are necessarily ambient, which makes them less natural to distribute along with the framework.

[PatrickJS]

@alexeagle while true I think it would help slowly introduce everyone to typescript. Angular 1 could allow global types from the default path import 'angular' but also allow import {} from 'angular/core'. There are already modules out there that usually allow for global as 'my-module/global' so why not use the same pattern. The default import is global support and everything else is the same workflow as Angular 2 that isn't global. imho a lot of Angular 2 concepts should be slowly introduced into the Angular 1 codebase without breaking the current workflow.

(The issue also became the highest upvoted issue in the repo if that counts for a feature demand)

[alexeagle]

Sounds reasonable - if we want to host the angular*.d.ts files in the
angular/angular.js repo and distribute with the release, we should make
sure our testing story includes compiling examples against those
definitions, so they are in sync with changes to the framework. I know
there are now mechanisms for external module to contribute ambient typings
(in TS 1.8?) so we can probably make this work seamlessly. We should also
make a pointer on DefinitelyTyped so no one tries to install from there in
the future (we don't want to have two different distribution paths)

On Thu, Mar 24, 2016 at 12:39 AM PatrickJS notifications@github.com wrote:

@alexeagle https://github.com/alexeagle while true I think it would
help slowly introduce everyone to typescript. Angular 1 could allow global
types from the default path import 'angular' but also allow import {}
from 'angular/core'. There are already globals out there that usually
allow for global as 'my-module/global' so why not use the same pattern.
The default import is global support and everything else is the same
workflow as Angular 2 that isn't global. imho a lot of Angular 2 concepts
should be slowly introduced into the Angular 1 codebase without breaking
the current workflow.

(The issue also became the highest upvoted issue in the repo if that
counts for a feature demand)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#14274 (comment)

[aciccarello]

I haven't updated to TypeScript 2.0, but does the ability to install DefinitelyTyped d.ts files via @types on npm change any of the value of this?

Automated verification would be the main advantage I'd see but I'm not sure how much work that'd take.

[alexeagle]

@types just changes the distribution mechanism, and their import script does a bit of cleaning up of the files (eg. ambient namespaces, relative links between the files)
It doesn't change the fundamentals here: getting the right content in the .d.ts that matches Angular APIs and verifying that it's not broken.