Skip to content

Fix default checkbox size to align with guidelines #17886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

martinlaws
Copy link

Fixes #17656

Both Material Designs Guidlines and Material Designs Sketch UI Kit show the default size of a checkbox as 18x18 (14x14 + 2px border) upon inspecting the code.

Fixes angular#17656

Both [Material Designs Guidlines](https://material.io/components/selection-controls/#) and [Material Designs Sketch UI Kit](https://storage.googleapis.com/material-design/downloads/material-design-stickersheet.sketch) show the default size of a checkbox as 18x18 (14x14 + 2px border) upon inspecting the code.
@martinlaws martinlaws requested a review from jelbourn as a code owner December 5, 2019 22:03
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Dec 5, 2019
@martinlaws martinlaws changed the title Fix default checkbox size to align with material Fix default checkbox size to align with guidelines Dec 5, 2019
@martinlaws
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Dec 5, 2019
@jelbourn
Copy link
Member

Thanks for the PR!

In a future version, we will be switching the checkbox to be based on MDC Web so that it more closely aligns with the most up-to-date version of the spec (instead of the 2016 version we started with).

We can't change this now, though, because it would effectively break the look (and possibly layout) of anyone using the checkbox (particularly inside Google). Something as major as changing the size of a component needs a gradual rollout across major versions.

@jelbourn jelbourn closed this Jan 16, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mat-checkbox: Change size to 18x18 to match Material Design Guidelines
3 participants