Fix Duplicate Lombok adapter generation (#260)

* fix primitive noop

* fix compilation error

* avoid duplicate generation with lombok

* Make NoOpValidator not public and final

---------

Co-authored-by: Rob Bygrave <robin.bygrave@gmail.com>

Author: SentryMan

validator-generator/src/main/java/io/avaje/validation/generator/TypeReader.java

@@ -129,7 +129,11 @@ int genericTypeParamsCount() {
 
   private boolean includeField(Element element) {
     return !element.getModifiers().contains(Modifier.TRANSIENT)
-        && (!element.getAnnotationMirrors().isEmpty() || element.asType().toString().contains("@"));
+        && (element.getAnnotationMirrors().stream()
+                //filter lombok's suppress warnings and generated annotations
+                .filter(m -> !m.toString().contains("@java"))
+                .anyMatch(m -> !m.toString().contains("lombok"))
+            || element.asType().toString().contains("@"));
   }
 
   private void readMethod(Element element, TypeElement type, List<FieldReader> localFields) {

validator/src/main/java/io/avaje/validation/core/CoreAdapterBuilder.java

@@ -25,8 +25,6 @@
 
 /** Builds and caches the ValidationAdapter adapters for DValidator. */
 final class CoreAdapterBuilder {
-  @SuppressWarnings("rawtypes")
-  public static final ValidationAdapter NOOP = (type, req, propertyName) -> true;
 
   private static final Set<Class<?>> DEFAULT_GROUP = Set.of(Default.class);
   private final DValidator context;
@@ -106,7 +104,7 @@ <T> ValidationAdapter<T> buildAnnotation(
       }
     }
     // unknown annotations have noop
-    return NOOP;
+    return NoOpValidator.INSTANCE;
   }
 
   record Request(

validator/src/main/java/io/avaje/validation/core/DValidator.java

@@ -164,7 +164,7 @@ public <T> ValidationAdapter<T> adapter(Type type) {
   @Override
   @SuppressWarnings("unchecked")
   public <T> ValidationAdapter<T> noop() {
-    return CoreAdapterBuilder.NOOP;
+    return NoOpValidator.INSTANCE;
   }
 
   @Override

validator/src/main/java/io/avaje/validation/core/NoOpValidator.java

@@ -0,0 +1,59 @@
+package io.avaje.validation.core;
+
+import io.avaje.validation.adapter.ValidationAdapter;
+import io.avaje.validation.adapter.ValidationRequest;
+
+final class NoOpValidator implements ValidationAdapter, ValidationAdapter.Primitive {
+
+  static final NoOpValidator INSTANCE = new NoOpValidator();
+
+  @Override
+  public boolean validate(Object value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public Primitive primitive() {
+    return this;
+  }
+
+  @Override
+  public boolean validate(boolean value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(byte value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(char value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(double value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(float value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(int value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(long value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+
+  @Override
+  public boolean validate(short value, ValidationRequest req, String propertyName) {
+    return true;
+  }
+}