Skip to content

Timeouts shouldn't hide assertion failures #1997

Open
@Marsup

Description

@Marsup

Issuehunt badges

Prerequisites

I checked other issues and couldn't find something similar, although #1485 is slightly related and is genuinely both surprising and completely counter-intuitive to me, but I'm not going to start this debate again.

Description

Test timeouts are hiding failed assertions.

Test Source

test('foo', t => {
  t.is(1, 2);
  return new Promise(() => {
    function f() {
      setTimeout(f, 10);
    }
    f();
  });
});

Error Message & Stack Trace

✖ Exited because no new tests completed within the last 2000ms of inactivity

That's all there is, no trace of the assertion.

Command-Line Arguments

ava --timeout=2s

Environment

Node.js v10.14.1
linux 4.18.0-12-generic
1.0.0-rc.2
6.4.1

There is a $40.00 open bounty on this issue. Add more on Issuehunt.

Activity

novemberborn

novemberborn commented on Jan 7, 2019

@novemberborn
Member

Agreed. This is ultimately a limitation of the reporters, though we currently don't send the results of individual assertions to the main process either. I'm adding the appropriate labels.

IssueHuntBot

IssueHuntBot commented on May 15, 2019

@IssueHuntBot

@IssueHunt has funded $40.00 to this issue.


yagyadeep786

yagyadeep786 commented on Mar 31, 2024

@yagyadeep786

I want to contribute and fix this bug.

novemberborn

novemberborn commented on Mar 31, 2024

@novemberborn
Member

@yagyadeep786 by all means. I don’t know if this is still an issue though, you’ll want to verify that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @novemberborn@Marsup@IssueHuntBot@yagyadeep786

        Issue actions

          Timeouts shouldn't hide assertion failures · Issue #1997 · avajs/ava