fix endpointUri regression

- fixes issue #392

Author: blakmatrix

.env.test

@@ -7,4 +7,5 @@ ZENDESK_TOKEN=myToken
 ZENDESK_PASSWORD=myPassword
 ZENDESK_SUBDOMAIN=nodejsapi
 ZENDESK_OAUTH_ACCESS_TOKEN=myOAuthAccessToken
+ZENDESK_ENDPOINT_URI=https://nodejsapi.zendesk.com/api/v2
 

src/clients/client.js

@@ -9,7 +9,6 @@ const {
   flatten,
   checkRequestResponse,
   processResponseBody,
-  generateUserAgent,
 } = require('./helpers');
 
 /**
@@ -51,7 +50,6 @@ class Client {
     this.sideLoad = [];
     this.jsonAPINames = [];
     this.useDotJson = true;
-    this.userAgent = generateUserAgent();
     this.eventTarget = new CustomEventTarget();
   }
 
@@ -95,7 +93,7 @@ class Client {
    * @private
    */
   _buildOptions(options, apiType = ApiTypes.core) {
-    const endpointUri = this._getEndpointUri(options.subdomain, apiType);
+    const endpointUri = options.endpointUri ?? this._getEndpointUri(options.subdomain, apiType);
     const data = {...options, endpointUri};
     return {
       ...data,

test/authentication.test.js

@@ -12,6 +12,7 @@ const password = process.env.ZENDESK_PASSWORD;
 const token = process.env.ZENDESK_TOKEN;
 const oauthAccessToken = process.env.ZENDESK_OAUTH_ACCESS_TOKEN;
 const TEST_USER = process.env.ZENDESK_FULL_NAME;
+const endpointUri = process.env.ZENDESK_ENDPOINT_URI;
 
 describe('Zendesk Client Authentication', () => {
   beforeAll(async () => {
@@ -108,4 +109,11 @@ describe('Zendesk Client Authentication', () => {
     await verifyUser(client, TEST_USER);
     nockDone();
   });
+
+  it('should authenticate a user with a valid endpoint', async () => {
+    const {nockDone} = await nockBack('authentication_test_endpoint_uri.json');
+    const client = setupClient({endpointUri, token, subdomain: undefined});
+    await verifyUser(client, TEST_USER);
+    nockDone();
+  });
 });

test/fixtures/authentication_test_endpoint_uri.json

@@ -0,0 +1,15 @@
+[
+    {
+        "scope": "https://nodejsapi.zendesk.com:443",
+        "method": "GET",
+        "path": "/api/v2/users/me.json",
+        "body": "",
+        "status": 200,
+        "response": {
+            "user": {
+              "name": "TEST USER"
+            }
+          },
+        "responseIsBinary": false
+    }
+]