Split combined getter/setter EntityInterface::isNew().

isNew() now only acts as getter and new method setNew() has been added as getter.

Author: ADmad

Association/BelongsToMany.php

@@ -769,7 +769,7 @@ protected function _saveLinks(EntityInterface $sourceEntity, array $targetEntiti
             // as new, we let save() sort out whether or not we have a new link
             // or if we are updating an existing link.
             if ($changedKeys) {
-                $joint->isNew(true);
+                $joint->setNew(true);
                 $joint->unset($junction->getPrimaryKey())
                     ->set(array_merge($sourceKeys, $targetKeys), ['guard' => false]);
             }

Behavior/Translate/EavStrategy.php

@@ -462,11 +462,11 @@ protected function bundleTranslatedFields($entity)
         foreach ($find as $i => $translation) {
             if (!empty($results[$i])) {
                 $contents[$i]->set('id', $results[$i], ['setter' => false]);
-                $contents[$i]->isNew(false);
+                $contents[$i]->setNew(false);
             } else {
                 $translation['model'] = $this->_config['referenceName'];
                 $contents[$i]->set($translation, ['setter' => false, 'guard' => false]);
-                $contents[$i]->isNew(true);
+                $contents[$i]->setNew(true);
             }
         }
 

Entity.php

@@ -62,7 +62,7 @@ public function __construct(array $properties = [], array $options = [])
         }
 
         if ($options['markNew'] !== null) {
-            $this->isNew($options['markNew']);
+            $this->setNew($options['markNew']);
         }
 
         if (!empty($properties) && $options['markClean'] && !$options['useSetters']) {

Table.php

@@ -1765,7 +1765,7 @@ public function save(EntityInterface $entity, $options = [])
             }
             if ($options['atomic'] || $options['_primary']) {
                 $entity->clean();
-                $entity->isNew(false);
+                $entity->setNew(false);
                 $entity->setSource($this->getRegistryAlias());
             }
         }
@@ -1813,7 +1813,7 @@ protected function _processSave(EntityInterface $entity, ArrayObject $options)
             foreach ($entity->extract($primaryColumns) as $k => $v) {
                 $conditions["$alias.$k"] = $v;
             }
-            $entity->isNew(!$this->exists($conditions));
+            $entity->setNew(!$this->exists($conditions));
         }
 
         $mode = $entity->isNew() ? RulesChecker::CREATE : RulesChecker::UPDATE;
@@ -1854,7 +1854,7 @@ protected function _processSave(EntityInterface $entity, ArrayObject $options)
 
         if (!$success && $isNew) {
             $entity->unset($this->getPrimaryKey());
-            $entity->isNew(true);
+            $entity->setNew(true);
         }
 
         return $success ? $entity : false;
@@ -1891,7 +1891,7 @@ protected function _onSaveSuccess(EntityInterface $entity, ArrayObject $options)
 
         if (!$options['atomic'] && !$options['_primary']) {
             $entity->clean();
-            $entity->isNew(false);
+            $entity->setNew(false);
             $entity->setSource($this->getRegistryAlias());
         }
 
@@ -2096,7 +2096,7 @@ protected function _saveMany(iterable $entities, $options = []): iterable
             foreach ($entities as $key => $entity) {
                 if (isset($isNew[$key]) && $isNew[$key]) {
                     $entity->unset($this->getPrimaryKey());
-                    $entity->isNew(true);
+                    $entity->setNew(true);
                 }
             }
         };