Skip to content

Wrong iFrame preview URL when viewing Latest version of a draft of a translation #500

Open
@marcorcau

Description

@marcorcau

Description

In a multi-language setup with workflow enabled and draft status, the iFrame preview URL is correctly calculated for all links in "Revisions" tab, which follow the URL structure: /[langcode]/node/[nid]/revisions/[vid]/view.

But the iFrame URL is wrong for drafts not in the node original language when visiting the "Latest revision" tab. URL in this case has the structure: /[langcode]/node/[nid]/latest.

In this case, the latest revision of the entity in its original language is displayed.

The following screenshot demonstrates the URL language in the browser is "de-ch" but the URL in the iFrame is "de":

imatge

In my screenshot in the preview frame an error appears, but that might be related to my setup. The important part is wrong langcode in the URL.

Steps to reproduce

In a basic Next.js 1.6.3 setup on Drupal 10

  • Enable language and workflow. Set multiple languages with URL detection method and workflow with Draft and Published statuses, and transitions between both of them.
  • Create a node in "Language 1".
  • Translate to "Language 2" and publish.
  • Edit again in "Language 2" and save as draft.
  • Click "Revisions" on translation and preview the first in the list -> Correct content will appear.
  • Click "Latest revision" -> The content in "Language 1" will appear.
  • Inspect frame URL -> The slug URL parameter contains language 1 langcode, not language 2.

Activity

added a commit that references this issue on May 23, 2023

Issue chapter-three#500: Fix wrong iFrame preview URL on "Latest vers…

apmsooner

apmsooner commented on Dec 8, 2023

@apmsooner
Contributor

This line is currently returning the node in the default language: https://github.com/chapter-three/next-drupal/blob/main/modules/next/src/NextEntityTypeManager.php#L80

It appears that commenting that out and just returning $parameter in line 85 loads the revision for the translated language correctly. I don't know if this is always the case or based on my current language detection settings. I can provide a patch for this if this is the right course of action... just not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @marcorcau@apmsooner

      Issue actions

        Wrong iFrame preview URL when viewing Latest version of a draft of a translation · Issue #500 · chapter-three/next-drupal