feat: Always allow non-DC reactions to create chats

iequidoo · iequidoo · commit 8e9c04644ceb · 2025-04-06T02:49:07.000-03:00
This also unifies conditions for creating chats for chatmail and non-chatmail with
`ShowEmails::All`. As for DC reaction messages, they don't contain extra parts, so they mustn't
create chats.
diff --git a/src/receive_imf.rs b/src/receive_imf.rs
@@ -781,7 +781,9 @@ async fn add_parts(
             ShowEmails::All => allow_creation = !is_mdn,
         }
     } else {
-        allow_creation = !is_mdn && !is_reaction;
+        // DC reaction messages don't contain extra parts, so they mustn't create chats.
+        let is_dc_reaction = is_dc_message == MessengerMessage::Yes && is_reaction;
+        allow_creation = !is_mdn && !is_dc_reaction;
     }
 
     // check if the message introduces a new chat:

Original file line number	Diff line number	Diff line change
`@@ -781,7 +781,9 @@ async fn add_parts(`
`781`	`781`	`ShowEmails::All => allow_creation = !is_mdn,`
`782`	`782`	`}`
`783`	`783`	`} else {`
`784`		`- allow_creation = !is_mdn && !is_reaction;`
	`784`	`+ // DC reaction messages don't contain extra parts, so they mustn't create chats.`
	`785`	`+ let is_dc_reaction = is_dc_message == MessengerMessage::Yes && is_reaction;`
	`786`	`+ allow_creation = !is_mdn && !is_dc_reaction;`
`785`	`787`	`}`
`786`	`788`
`787`	`789`	`// check if the message introduces a new chat:`