Skip to content

fix: [DebugBar] regex backtracking #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: [DebugBar] regex backtracking #7325

wants to merge 1 commit into from

Conversation

fliodhais
Copy link

@fliodhais fliodhais commented Mar 2, 2023 •
edited
Loading

Description
updated regex to fix #7324

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the GPG-Signing needed Pull requests that need GPG-Signing label Mar 3, 2023
@kenjis kenjis changed the title fix #7324 backtracking fix: [DebugBar] regex backtracking Mar 3, 2023
@kenjis
Copy link
Member

kenjis commented Mar 4, 2023

@fliodhais Thank you for sending PR.
Please sign your commits.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

@fliodhais
fix #7324
9d2c8ba 
add GPG-signing
@fliodhais
Copy link
Author

Sorry it took so long, was learning how to config signing with GH desktop and signing old commits.

@kenjis kenjis removed the GPG-Signing needed Pull requests that need GPG-Signing label Mar 10, 2023
@kenjis
Copy link
Member

kenjis commented Mar 22, 2023

This does not work.

Uncaught SyntaxError: invalid regexp group
    onreadystatechange http://localhost:8080/index.php?debugbar:37
    loadDoc http://localhost:8080/index.php?debugbar:14
    EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1

@kenjis kenjis closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [DebugBar] regex vulnerable to super-linear runtime due to backtracking
3 participants
@fliodhais @kenjis @ddevsr