Bugfix: Change .pop() to .shift()

node9 · node9 · commit a2d6495dd5e8 · 2016-10-07T17:47:21.000Z
diff --git a/lib/ConcurrencyQueue.js b/lib/ConcurrencyQueue.js
@@ -47,7 +47,7 @@ ConcurrencyQueue.prototype.drain = function (jobId) {
         this.emit('drained', job, jobId, this.currentStatus());
         job = null;
         if (this.waitingQ.length > 0) {
-            this.release(this.waitingQ.pop());
+            this.release(this.waitingQ.shift());
         }
         this.checkEmpty();
     } else {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ ConcurrencyQueue.prototype.drain = function (jobId) {`
`47`	`47`	`this.emit('drained', job, jobId, this.currentStatus());`
`48`	`48`	`job = null;`
`49`	`49`	`if (this.waitingQ.length > 0) {`
`50`		`- this.release(this.waitingQ.pop());`
	`50`	`+ this.release(this.waitingQ.shift());`
`51`	`51`	`}`
`52`	`52`	`this.checkEmpty();`
`53`	`53`	`} else {`