-
Notifications
You must be signed in to change notification settings - Fork 772
[temp.over.link] Remove (apparent) copy/paste extra lines from example code #4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The first two lines in this example were an exact copy from the previous example, and seem unrelated to the topic being demonstrated.
The example demonstrates that
I don't think it's an error. |
It seems to me you're taking the text describing example 2, while my proposed change is for example 3 (which is about dependent names). Both examples 2 and 3 contain these exact same lines, and it is correct in example 2, but appears to be copy-paste leftover in example 3.
|
@jensmaurer, @opensdh: could you kindly take a look? The original wording seems to have been in place since the initial commit. |
I agree this repeats parts of the earlier example, but it seems as relevant to the given paragraph ("equivalent") as to the previous one. Maybe the second line of the previous example should actually be removed, because the paragraph specifies that dependent expressions are part of the signature (difference between + and - in the return type), not that template parameter renames are benign. |
It's not actually "an exact copy from the previous example": it uses a parameter type instead of a return type. I tend to agree with @jensmaurer that removing the one line from the previous example is a more useful simplification. |
My apologies for imprecise phrasing. It _looked_ enough like the previous
example that I thought it was a cut and paste issue, but you are correct
and my confusion was partially my own fault. However, it does seem that
there's room for improvement, so thanks for taking time to look at this.
…On Thu, Jun 10, 2021 at 2:11 PM Davis Herring ***@***.***> wrote:
It's not actually "an exact copy from the previous example": it uses a
parameter type instead of a return type. I tend to agree with @jensmaurer
<https://github.com/jensmaurer> that removing the one line from the
previous example is a more useful simplification.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4396 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEU3D3UUUWBA5KYIQFQVXZTTSEE6JANCNFSM4UFRW2TA>
.
|
@cuzdav: could you make the suggested change, or would you like me to? |
The first two lines in this example were an exact copy from the
previous example (about 40 lines up), and seem unrelated to the
topic being demonstrated, so look like a cut/paste error.