Send client metric only in production

Author: rubenmoya

.eslintrc.json

@@ -6,6 +6,7 @@
     "jasmine": true
   },
   "globals": {
+    "__ENV__": true
   },
   "rules": {
     "no-useless-escape": "off"

package.json

@@ -149,8 +149,8 @@
     "test:browser": "grunt dev",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
-    "build": "rm -rf dist/public; webpack --config webpack/webpack.config.js && webpack --config webpack/webpack.min.config.js",
-    "build:watch": "webpack -w --config webpack/webpack.config.js",
+    "build": "rm -rf dist/public; NODE_ENV=production webpack --config webpack/webpack.config.js && NODE_ENV=production webpack --config webpack/webpack.min.config.js",
+    "build:watch": "NODE_ENV=development webpack -w --config webpack/webpack.config.js",
     "build:internal": "grunt build",
     "docs": "rm -rf docs/public; jsdoc --configure config/jsdoc/public-conf.json",
     "docs:internal": "rm -rf docs/internal; jsdoc --configure config/jsdoc/internal-conf.json",

src/engine.js

@@ -291,20 +291,26 @@ Engine.prototype._buildOptions = function (options) {
  * @private
  */
 Engine.prototype._buildParams = function (includeFilters) {
-  var params = {
-    client: this._windshaftSettings.client
-  };
+  var params = {};
+
+  if (__ENV__ === 'production') {
+    params.client = this._windshaftSettings.client;
+  }
+
   if (includeFilters && !_.isEmpty(this._dataviewsCollection.getFilters())) {
     params.filters = this._dataviewsCollection.getFilters();
   }
+
   if (this._windshaftSettings.apiKey) {
     params.api_key = this._windshaftSettings.apiKey;
     return params;
   }
+
   if (this._windshaftSettings.authToken) {
     params.auth_token = this._windshaftSettings.authToken;
     return params;
   }
+
   console.warn('Engine initialized with no apiKeys neither authToken');
 };
 

webpack/webpack.config.js

@@ -12,6 +12,9 @@ module.exports = {
   },
   devtool: 'sourcemap',
   plugins: [
+    new webpack.DefinePlugin({
+      __ENV__: JSON.stringify(process.env.NODE_ENV)
+    }),
     // Include only the lastest camshaft-reference
     new webpack.IgnorePlugin(/^\.\/((?!0\.59\.4).)*\/reference\.json$/),
     new webpack.BannerPlugin(banner)

webpack/webpack.min.config.js

@@ -12,6 +12,9 @@ module.exports = {
     libraryTarget: 'umd'
   },
   plugins: [
+    new webpack.DefinePlugin({
+      __ENV__: JSON.stringify(process.env.NODE_ENV)
+    }),
     // Include only the lastest camshaft-reference
     new webpack.IgnorePlugin(/^\.\/((?!0\.59\.4).)*\/reference\.json$/),
     new UglifyJsPlugin(),