Skip to content

BUG: A motoko upgrade should never have the option to ignore stable compatiblity errors. #4183

Open
@crusso

Description

@crusso

The code here:

if !skip_consent && canister_info.is_motoko() && matches!(mode, InstallMode::Upgrade { .. }) {

is dangerous because it permits the user ignore any stable compatibility errors which may lead to loss of data.

This is more dangerous than ignoring the candid compatibility error, because users can always fix the candid interface with an upgrade, but once data is lost, it's gone or corrupted forever.

Is it possible to skip/ask for consent on stable compatibility warnings only but never, ever ignore stable compatibility errors?

@luc-blaeser - do you agree with proposal?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions