Skip to content

make CliAction.Invoke* methods protected, so users can not invoke them #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

make CliAction.Invoke* methods protected, so users can not invoke them #2165

wants to merge 1 commit into from

Conversation

adamsitnik
Copy link
Member

The goal is to make it mandatory to override both methods when deriving a custom type from CliAction, but make it impossible to call them instead of ParseResult.Invoke* methods.

@jonsequitur I wanted to quickly iterate over this proof of concept, if it's not helpful and/or ready just close it.

fixes #2154

@adamsitnik adamsitnik requested a review from jonsequitur April 12, 2023 18:47
@jonsequitur
Copy link
Contributor

I believe this would undo one of the intents of the CliAction design, which is to be able to call an action directly. We're doing some additional design work around this currently.

@adamsitnik adamsitnik closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur Awaiting requested review from jonsequitur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It should be dirt simple to replace or augment CliActions
2 participants
@adamsitnik @jonsequitur