Factor out method to get modulename(s)

This might be useful for easyblocks to avoid duplicating the code for
determining the modulename from either the options or the name.

Author: Flamefire

easybuild/framework/extension.py

@@ -45,21 +45,13 @@
 from easybuild.tools.run import run_shell_cmd
 
 
-def construct_exts_filter_cmds(exts_filter, ext):
-    """
-    Resolve the exts_filter tuple by replacing the template values using the extension
-    :param exts_filter: Tuple of (command, input) using template values (ext_name, ext_version, src)
+def get_modulenames(ext, use_name_for_false):
+    """Return a list of modulenames for the extension
     :param ext: Instance of Extension or dictionary like with 'name' and optionally 'options', 'version', 'source' keys
-    :return: (cmd, input) as a tuple of strings for each modulename. Might be empty if no filtering is intented
+    :param use_name_for_false: Whether to return a list with the name or an empty list when the modulename is False
     """
-
-    if isinstance(exts_filter, str) or len(exts_filter) != 2:
-        raise EasyBuildError('exts_filter should be a list or tuple of ("command","input")')
-
-    cmd, cmdinput = exts_filter
-
     if not isinstance(ext, dict):
-        ext = {'name': ext.name, 'version': ext.version, 'src': ext.src, 'options': ext.options}
+        ext = {'name': ext.name, 'options': ext.options}
 
     try:
         modulenames = ext['options']['modulename']
@@ -71,11 +63,31 @@ def construct_exts_filter_cmds(exts_filter, ext):
                 raise EasyBuildError(f"Empty modulename list for {ext['name']} is not supported."
                                      "Use `False` to skip checking the module!")
         elif modulenames is False:
-            return []  # Skip any checks
+            return [ext['name']] if use_name_for_false else []
         elif not isinstance(modulenames, str):
             raise EasyBuildError(f"Wrong type of modulename for {ext['name']}: {type(modulenames)}: {modulenames}")
         else:
             modulenames = [modulenames]
+    return modulenames
+
+
+def construct_exts_filter_cmds(exts_filter, ext):
+    """
+    Resolve the exts_filter tuple by replacing the template values using the extension
+    :param exts_filter: Tuple of (command, input) using template values (ext_name, ext_version, src)
+    :param ext: Instance of Extension or dictionary like with 'name' and optionally 'options', 'version', 'source' keys
+    :return: (cmd, input) as a tuple of strings for each modulename. Might be empty if no filtering is intented
+    """
+
+    if isinstance(exts_filter, str) or len(exts_filter) != 2:
+        raise EasyBuildError('exts_filter should be a list or tuple of ("command","input")')
+
+    cmd, cmdinput = exts_filter
+
+    if not isinstance(ext, dict):
+        ext = {'name': ext.name, 'version': ext.version, 'src': ext.src, 'options': ext.options}
+
+    modulenames = get_modulenames(ext, use_name_for_false=False)
 
     result = []
     for modulename in modulenames: