Inconsistencies and Missing SVG Files

[Michael5601]

In this repository there are two folders eclipse-png and eclipse-svg that should have the same structure. The first contains PNGs and the second SVGs.

For the SVG rasterization feature that was introduces in this PR we need a SVG image file for every raster image file (e.g. .png or .gif).

In the following, I present a list of all inconsistencies or missing SVG files that I found, grouped by the specific problem:

Naming inconsistencies:

1. debuglast_co:

   • PNG: org.eclipse.debug.ui\icons\full\elcl16\debuglast_co.gif.png (debuglast_co.png also exists at this location but it's the same icon)
   • SVG: org.eclipse.debug.ui\icons\full\elcl16\debuglast_co.svg

2. file-delete-line-12x12:

   • PNG: org.eclipse.mylyn.tasks.ui\icons\etool12\file-delete-line12x12.png (file-delete-line-12x12 also exists at this location but it's the same icon)
   • SVG: org.eclipse.mylyn.tasks.ui\icons\etool12\file-delete-line-12x12.svg

Location inconsistencies:

1. Eclipse-Icon

   • PNG:

     eclipse.platform.releng.tychoeclipsebuilder\eclipse.platform.repository\icons\Eclipse.iconset\icon_128x128.png
     eclipse.platform.releng.tychoeclipsebuilder\eclipse.platform.repository\icons\Eclipse.iconset\icon_16x16.png
     eclipse.platform.releng.tychoeclipsebuilder\eclipse.platform.repository\icons\Eclipse.iconset\icon_256x256.png
     eclipse.platform.releng.tychoeclipsebuilder\eclipse.platform.repository\icons\Eclipse.iconset\icon_32x32.png
     eclipse.platform.releng.tychoeclipsebuilder\eclipse.platform.repository\icons\Eclipse.iconset\icon_512x512.png
     

   • SVG: eclipse.platform.releng.tychoeclipsebuilder\eclipse.platform.repository\icons\Eclipse.icns.svg

2. dragHandle:

   • PNG: org.eclipse.e4.ui.model.workbench.edit\images\dragHandle.png (This folder does not exist in eclipse-svg)
   • SVG: org.eclipse.e4.ui.workbench.swt\images\dragHandle.svg

3. dragHandle-rotated:

   • PNG: org.eclipse.e4.ui.model.workbench.edit\images\dragHandle-rotated.png (This folder does not exist in eclipse-svg)
   • SVG: org.eclipse.e4.ui.workbench.swt\images\dragHandle-rotated.svg

4. att_file_obj: (Fix requested in PR)
   - PNG: org.eclipse.mylyn.tasks.ui\icons\etool12\att_file_obj.png
   - SVG: org.eclipse.pde.ui\icons\obj16\att_file_obj.svg

5. correction_change: (Fix requested in PR)
   - PNG: org.eclipse.mylyn.tasks.ui\icons\etool12\correction_change.png
   - SVG: org.eclipse.pde.api.tools.ui\icons\full\obj16\correction_change.svg

6. synced: (Fix requested in PR)
   - PNG: org.eclipse.ui.browser\icons\clcl16\synced.png
   - SVG: org.eclipse.ui\icons\full\elcl16\synced.svg

7. Wrong folder location:

   • PNG: org.eclipse.ui.externaltools\full\obj16\
   • SVG: org.eclipse.ui.externaltools\icons\full\obj16

8. delete_edit: (Fix requested in PR)
   - PNG: org.eclipse.ui.workbench.texteditor\icons\full\elcl16\delete_edit.png
   - SVG: org.eclipse.pde.ui\icons\elcl16\delete_edit.svg

9. select_next: (Fix requested in PR)
   - PNG: org.eclipse.ui.workbench.texteditor\icons\full\elcl16\select_next.png
   - SVG: org.eclipse.jdt.junit\icons\full\elcl16\select_next.svg

10. select_prev: (Fix requested in PR)
    - PNG: org.eclipse.ui.workbench.texteditor\icons\full\elcl16\select_prev.png
    - SVG: org.eclipse.jdt.junit\icons\full\elcl16\select_prev.svg

SVG does not exist:

Platform-bundles

1. org.eclipse.ant.ui:

• obj16/eclipse16
• wizban/ant_wiz
• wizban/export_ant_wiz

2. org.eclipse.ui.intro:

• etool16/restore_welcome.svg

3. org.eclipse.platform:

• all icons in images folder

4. org.eclipse.debug.ui.launchview:

• coverage.svg
• delete_exc.svg
• favorite_star.svg

5. org.eclipse.debug.ui:

• obj16\launchConfiguration

Platform-UI-bundles

6. org.eclipse.ui.ide:

• eview16/problems_view_info

7. org.eclipse.ui.ide.application:

• elcl16/split_horizontal.svg
• elcl16/split_vertical.svg

8. org.eclipse.ltk.ui.refactoring:

• wizban/apply_rescript_wiz.svg
• wizban/create_rescript_wiz.svg
• wizban/show_history_wiz.svg

9. org.eclipse.ui:

• etool16/search.svg

10. org.eclipse.ui.editors:

• etool16/next_edit_pos

11. org.eclipse.ui.workbench.texteditor:

• elcl16/open_history.svg

Mylyn-Bundles

12. org.eclipse.mylyn.tasks.ui:

• wizban/banner-repository.svg
• wizban/banner-repository-context.svg
• wizban/banner-repository-settings.svg
• wizban/bug-wizard.svg
• wizban/secur_role_wiz.svg

13. org.eclipse.mylyn.wikitext.ui:

• org.eclipse.mylyn.internal.wikitext.ui.util.resources/missing-image.svg

JDT-Debug-Bundles

14. org.eclipse.jdt.debug.ui:

• obj16/groupedframe.svg
• obj16/javastacktrace_console.svg
• obj16/jexcept_obj.svg

15. org.eclipse.jdt.launching.ui.macosx:

• ctool16/exportappbundle_wiz.svg
• wizban/exportapp_wiz.svg

JDT-UI-Bundles

16. org.eclipse.jdt.ui:

• etool16/move_up.svg
• wizban/newrecord_wiz.svg

PDE-Bundles

17. org.eclipse.pde.api.tools.ui:

• obj16/eclipse16.svg

18. org.eclipse.pde.spy.context:

• splash.svg (I don't know if this is used somewhere)

19. org.eclipse.pde.spy.core:

• spyicon.svg

19. org.eclipse.pde.spy.model:

• application_lightning.svg

20. org.eclipse.pde.spy.model:

• almost all icons from this bundle. SVGs with the same name are available but they look different.

21. org.eclipse.pde.ui:

• bndtools/bndrun.svg
• bndtools/bundle.svg
• bndtools/database.svg
• elcl16/cleanmanifest.svg
• etool16/eclipse.svg
• obj16/eclipse.svg

22. org.eclipse.pde.ui.templates:

• etool16/e4.svg

Icons of Test or Example bundles that are persisted as GIF

In addition to all icons listed above I want to mention that many example/test bundles also do not have related SVGs for their icons. This is probably fine as they are only used in development. The following list contains some examples:

• eclipse.platform\runtime\bundles\org.eclipse.core.tools\icons
• eclipse.platform.ui\examples\org.eclipse.ui.examples.job\icons
• eclipse.platform.ui\tests\org.eclipse.ui.tests\icons
• eclipse.platform.ui\examples\org.eclipse.ui.examples.contributions\icons
• eclipse.platform.ui\examples\org.eclipse.ui.examples.readmetool\icons\obj16
• eclipse.platform.ui\examples\org.eclipse.ui.examples.contributions\icons
• eclipse.platform.ui\tests\org.eclipse.ui.tests.views.properties.tabbed\icons

[Michael5601]

Please note that to fix the location inconsistencies the specific SVGs should not be moved but rather copied as they are needed in both locations.

I will fix these issues soon. Can someone give me some information about why the GIFs from the last problem are not part of this repository?

[BeckerWdf]

Can someone give me some information about why the GIFs from the last problem are not part of this repository?

What do you mean with "last problem"?

[Michael5601]

Can someone give me some information about why the GIFs from the last problem are not part of this repository?

What do you mean with "last problem"?

I mean the part "Icons that are not part of this repository but loaded at runtime of the Eclipse IDE"

[BeckerWdf]

Can someone give me some information about why the GIFs from the last problem are not part of this repository?

What do you mean with "last problem"?

I mean the part "Icons that are not part of this repository but loaded at runtime of the Eclipse IDE"

So maybe these icons may simply not yet migrated from GIF to PNG/SVG.

[Michael5601]

So maybe these icons may simply not yet migrated from GIF to PNG/SVG.

I guess so, but I wanted your feedback before I started creting the SVGs. This will be a lot of work but it is mandatory for having a consistent look for the icons once the SVG feature is merged.

[BeckerWdf]

So maybe these icons may simply not yet migrated from GIF to PNG/SVG.

I guess so, but I wanted your feedback before I started creting the SVGs. This will be a lot of work but it is mandatory for having a consistent look for the icons once the SVG feature is merged.

So for GIFs in examples / tests I would be a bit more relaxed.. ,-)

[Michael5601]

So for GIFs in examples / tests I would be a bit more relaxed.. ,-)

Yes you are right. I just wondered because they were all loaded in a standard Eclipse Application. I tried out different perspectives and all folders that I listed contain at least one icon that was loaded into Eclipse even though almost all of them are examples / tests.

[HeikoKlare]

org.eclipse.ui.ide:

eview16/problems_view_info

This one is quite "criticial", as it does not even have an @2x version.