Skip to content

MacOS wheels fail to build with Rust v1.83.0 #17988

Open
@anoadragon453

Description

@anoadragon453

The build release artifacts CI job has begun to fail on develop since November 28th. This lines up with Rust's v1.83.0 release on the same day. This portion of the release notes caught my and @sandhose's eye:

Linking on macOS now correctly includes Rust’s default deployment target. Due to a linker bug, you might have to pass MACOSX_DEPLOYMENT_TARGET or fix your #[link] attributes to point to the correct frameworks. See rust-lang/rust#129369.

As a temporary solution, building MacOS wheels were disabled in order to get out the 1.120.1 release.

Addressing this properly can be done in two stages:

  • Pin the Rust version used when building MacOS wheels to 1.82.0. This will allow MacOS wheels to be created again.

    The rust version that is used for building wheels is determined here. Changing stable to 1.82.0 should work.

    This has been done in Pin Rust to 1.82.0 when building Python wheels #17993.

  • Fixing the issue properly on the most recent Rust versions. This may involve setting MACOSX_DEPLOYMENT_TARGET as the Rust 1.83.0 changelog notes?

Completing 1. is considered a release blocker for 1.121.0rc1.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions