Checkstyle with checkstyle 9.3

Author: dmikurube

build.gradle

@@ -189,11 +189,11 @@ tasks.withType(Checkstyle) {
 }
 
 checkstyle {
-    toolVersion "8.7"
+    toolVersion = libs.versions.checkstyle.get()
     configFile = file("${rootProject.projectDir}/config/checkstyle/checkstyle.xml")
     configProperties = [
-        "checkstyle.config.path": file("${projectDir}/config/checkstyle")
+        "org.checkstyle.google.suppressionfilter.config": file("${rootProject.projectDir}/config/checkstyle/checkstyle-suppressions.xml"),
     ]
     ignoreFailures = false
-    maxWarnings = 0  // https://github.com/gradle/gradle/issues/881
+    maxWarnings = 0
 }

config/checkstyle/README.md

@@ -1,12 +1,11 @@
 Checkstyle for the Embulk project
 ==================================
 
-* google_check.xml: Downloaded from: https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml
-     * Commit: 60f41e3c16e6c94b0bf8c2e5e4b4accf4ad394ab
+* google_check.xml: Downloaded from: https://github.com/checkstyle/checkstyle/blob/checkstyle-9.3/src/main/resources/google_checks.xml
+     * Commit: 5c1903792f8432243cc8ae5cd79a03a004d3c09c
 * checkstyle.xml: Customized from google_check.xml.
-    * To enable suppressions through suppressions.xml.
+    * To enable suppressions through checkstyle-suppressions.xml.
     * To enable suppressions with @SuppressWarnings.
-    * To accept package names with underscores.
     * To indent with 4-column spaces.
-    * To limit columns to 180 characters, which will be shortened later.
+    * To limit columns to 180 characters.
     * To reject unused imports.

config/checkstyle/suppressions.xml renamed to config/checkstyle/checkstyle-suppressions.xml

@@ -8,6 +8,7 @@
   <suppress checks="JavadocMethod" files=".*"/>
   <suppress checks="JavadocParagraph" files=".*"/>
   <suppress checks="JavadocTagContinuationIndentation" files=".*"/>
+  <suppress checks="MissingJavadocType" files=".*"/>
   <suppress checks="SingleLineJavadoc" files=".*"/>
   <suppress checks="SummaryJavadoc" files=".*"/>
 </suppressions>

config/checkstyle/checkstyle.xml

@@ -20,7 +20,7 @@ configurations {
 }
 
 tasks.withType(JavaCompile) {
-    options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation"
+    options.compilerArgs << "-Xlint:deprecation" << "-Xlint:unchecked"
     options.encoding = "UTF-8"
 }
 
@@ -67,6 +67,19 @@ javadocJar {
     }
 }
 
+// A safer and strict alternative to: "dependencies" (and "dependencies --write-locks")
+//
+// This task fails explicitly when the specified dependency is not available.
+// In contrast, "dependencies (--write-locks)" does not fail even when a part the dependencies are unavailable.
+//
+// https://docs.gradle.org/8.7/userguide/dependency_locking.html#generating_and_updating_dependency_locks
+task checkDependencies {
+    notCompatibleWithConfigurationCache("The task \"checkDependencies\" filters configurations at execution time.")
+    doLast {
+        configurations.findAll { it.canBeResolved }.each { it.resolve() }
+    }
+}
+
 publishing {
     publications {
          maven(MavenPublication) {
@@ -154,11 +167,11 @@ tasks.withType(Checkstyle) {
 }
 
 checkstyle {
-    toolVersion "8.7"
+    toolVersion = libs.versions.checkstyle.get()
     configFile = file("${rootProject.projectDir}/config/checkstyle/checkstyle.xml")
     configProperties = [
-        "checkstyle.config.path": file("${rootProject.projectDir}/config/checkstyle")
+        "org.checkstyle.google.suppressionfilter.config": file("${rootProject.projectDir}/config/checkstyle/checkstyle-suppressions.xml"),
     ]
     ignoreFailures = false
-    maxWarnings = 0  // https://github.com/gradle/gradle/issues/881
+    maxWarnings = 0
 }

config/checkstyle/google_checks.xml

@@ -20,6 +20,8 @@ commons-codec = "1.16.1"
 commons-io = "2.16.1"
 commons-lang3 = "3.14.0"
 
+checkstyle = "9.3"
+
 [libraries]
 
 embulk-spi = { group = "org.embulk", name = "embulk-spi", version.ref = "embulk-spi" }