Skip to content

Commit 5cb41fc

Browse files
committed
Checkstyle with checkstyle 9.3
1 parent 48d9d1f commit 5cb41fc

File tree

6 files changed

+674
-419
lines changed

6 files changed

+674
-419
lines changed

build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,11 @@ tasks.withType(Checkstyle) {
170170
}
171171

172172
checkstyle {
173-
toolVersion "8.7"
173+
toolVersion = libs.versions.checkstyle.get()
174174
configFile = file("${rootProject.projectDir}/config/checkstyle/checkstyle.xml")
175175
configProperties = [
176-
"checkstyle.config.path": file("${projectDir}/config/checkstyle")
176+
"org.checkstyle.google.suppressionfilter.config": file("${rootProject.projectDir}/config/checkstyle/checkstyle-suppressions.xml"),
177177
]
178178
ignoreFailures = false
179-
maxWarnings = 0 // https://github.com/gradle/gradle/issues/881
179+
maxWarnings = 0
180180
}

config/checkstyle/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
Checkstyle for the Embulk project
22
==================================
33

4-
* google_check.xml: Downloaded from: https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml
5-
* Commit: 60f41e3c16e6c94b0bf8c2e5e4b4accf4ad394ab
4+
* google_check.xml: Downloaded from: https://github.com/checkstyle/checkstyle/blob/checkstyle-9.3/src/main/resources/google_checks.xml
5+
* Commit: 5c1903792f8432243cc8ae5cd79a03a004d3c09c
66
* checkstyle.xml: Customized from google_check.xml.
7-
* To enable suppressions through suppressions.xml.
7+
* To enable suppressions through checkstyle-suppressions.xml.
88
* To enable suppressions with @SuppressWarnings.
9-
* To accept package names with underscores.
109
* To indent with 4-column spaces.
11-
* To limit columns to 180 characters, which will be shortened later.
10+
* To limit columns to 180 characters.
1211
* To reject unused imports.

config/checkstyle/suppressions.xml renamed to config/checkstyle/checkstyle-suppressions.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<suppress checks="JavadocMethod" files=".*"/>
99
<suppress checks="JavadocParagraph" files=".*"/>
1010
<suppress checks="JavadocTagContinuationIndentation" files=".*"/>
11+
<suppress checks="MissingJavadocType" files=".*"/>
1112
<suppress checks="SingleLineJavadoc" files=".*"/>
1213
<suppress checks="SummaryJavadoc" files=".*"/>
1314
</suppressions>

0 commit comments

Comments
 (0)