Skip to content

Commit dcba4b8

Browse files
committed
WIP test all node.js unpipe
1 parent 9695001 commit dcba4b8

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
"eslint-plugin-standard": "4.0.0",
2929
"istanbul": "0.4.5",
3030
"mocha": "6.1.4",
31-
"supertest": "4.0.2"
31+
"supertest": "4.0.2",
32+
"unpipe": "1.0.0"
3233
},
3334
"files": [
3435
"LICENSE",

test/compression.js

+2-7
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ var bytes = require('bytes')
55
var crypto = require('crypto')
66
var http = require('http')
77
var request = require('supertest')
8+
var unpipe = require('unpipe')
89
var zlib = require('zlib')
910

1011
var compression = require('..')
@@ -456,12 +457,6 @@ describe('compression()', function () {
456457
})
457458

458459
it('should not leak event listeners when res.unpipe() is used (#135)', function (done) {
459-
// unpipe and stream.Readable were added in v0.9.4
460-
var stream = require('stream')
461-
if (!(stream.Readable && stream.Readable.prototype.unpipe)) {
462-
this.skip()
463-
}
464-
465460
var hasWarned = false
466461
var onWarning = function () {
467462
hasWarned = true
@@ -471,7 +466,7 @@ describe('compression()', function () {
471466
var int = setInterval(function () {
472467
var rs = require('fs').createReadStream('does not exist')
473468
rs.on('error', function (e) {
474-
rs.unpipe(res)
469+
unpipe(rs)
475470
})
476471
rs.pipe(res)
477472
if (times++ > res.getMaxListeners()) {

0 commit comments

Comments
 (0)