Skip to content

Complete Current Statement does some strange things #2544

Open
@xster

Description

@xster

aug-15-2018 21-42-36

Since Flutter's all about chains of constructors, perhaps it should try to do something with the current constructor instead.

Activity

devoncarew

devoncarew commented on Aug 16, 2018

@devoncarew
Member
added this to the Backlog milestone on Aug 16, 2018
xster

xster commented on Aug 16, 2018

@xster
MemberAuthor

Somewhat related, maybe the analysis server doesn't support complete current statement at all. Would be nice to be able to import 'something.dart', press the key combo and get the ; and go to next line

stevemessick

stevemessick commented on Aug 16, 2018

@stevemessick
Member

Thanks, that's a good suggestion. It didn't occur to me before. I added it for Dart about a year ago and I think @scheglov has made some improvements since then.

I think the original request is more of a new feature, though, since it isn't really completing the statement. It is more like "do what I mean here in this constructor" and, yes, could be really useful for Flutter. What should have happened in this case?

xster

xster commented on Aug 17, 2018

@xster
MemberAuthor

A bit of both I think.

Right now, completing on var a = 1 + 1 doesn't add a semi column.

In the Flutter case above, I'd say add a comma and insert and go to a next line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pq@xster@devoncarew@stevemessick

        Issue actions

          Complete Current Statement does some strange things · Issue #2544 · flutter/flutter-intellij