Skip to content

Improve Ctrl+Shift+Enter #3253

Open
Open
@feinstein

Description

@feinstein

Ctrl+Shift+Enter is supposed to complete the current sentence and go to the next line. Currently for Dart it's not working very well, it doesn't add a ; at the end of the line before jumping to the next line, please improve it if possible.

Activity

pq

pq commented on Mar 5, 2019

@pq
Contributor
added this to the Backlog milestone on Mar 5, 2019
alexander-doroshko

alexander-doroshko commented on Mar 5, 2019

@alexander-doroshko
Contributor

@pq No changes in Dart plugin required, the feature comes from the server. Cc @stevemessick

@feinstein It works for me, at least in some cases like this one:
image
Note that each case is handled separately, so please paste specific examples when it doesn't work. I guess the right issue tracker for this is https://github.com/dart-lang/sdk/issues/, label: area-analyzer.

feinstein

feinstein commented on Mar 5, 2019

@feinstein
Author

@alexander-doroshko this doesn't work for me:

int test() => 1
alexander-doroshko

alexander-doroshko commented on Mar 5, 2019

@alexander-doroshko
Contributor
pq

pq commented on Mar 5, 2019

@pq
Contributor

@pq No changes in Dart plugin required, the feature comes from the server.

Of course, yes. Sorry to mis-remember. Thanks @alexander-doroshko !

feinstein

feinstein commented on Mar 6, 2019

@feinstein
Author

Another thing, if I have this:

String _padLeftAndRight(String text)

  @override
Widget build(BuildContext context) {

and I hit Ctrl+Shift+Enter at the end of (String text), this is what is generated:

  String _padLeftAndRight(String text)

  {
    
  } @override
  Widget build(BuildContext context) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pq@alexander-doroshko@feinstein

        Issue actions

          Improve Ctrl+Shift+Enter · Issue #3253 · flutter/flutter-intellij