Skip to content

Track down all manual calls to dispose() in the IntelliJ Plugin #6077

Open
@jacob314

Description

@jacob314

Some classes like FlutterWidgetPerf
implement the Disposable interface but have dispose()
called manually which is counter to how dispose() should be called for a properly functioning IntelliJ plugin.

Mixing manual and automatic calls to dispose leads to confusing bugs like
#6042

Activity

added this to the On Deck milestone on Apr 4, 2022
stevemessick

stevemessick commented on Apr 15, 2022

@stevemessick
Member

FlutterWidgetPerf.dispose() is called by FlutterWidgetPerfManager.dispose(), which is itself never called due to using the project as a dispose parent: Disposer.register(project, this);

We need to fix #6076 before working on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @jacob314@stevemessick

        Issue actions

          Track down all manual calls to dispose() in the IntelliJ Plugin · Issue #6077 · flutter/flutter-intellij