Fullscreen on landsacpe

[cbenhagen]

It would be nice if the player could automatically switch to fullscreen mode when the device is currently in (or when being rotated to) landscape mode.

[brianegan]

Thanks for the feedback, I'll look at how each platform handles those rotations and see how I can improve it. Also, please feel free to contribute if this is functionality ya need more immediately! Might be a week or more before I can look at this.

[cbenhagen]

Thank you for the quick response. I already tried to dig into your code (and the video_player plugin) to see how to possibly add that functionality myself but I doubt I am able to do this right now as I am very new to dart/flutter and have never touched java/swift code. But hey maybe with some guidance I might come up with a PR. Let me know if you have an idea how it could be done and I give it a try.

[cbenhagen]

My initial thought was to use an OrientationBuilder and tell the VideoPlayerController or Chewie to go fullscreen. But that does not seem to be possible.

[cbenhagen]

What do you mean by looking at how each platform handles those rotations? Technically or from a user experience standpoint? The Youtube and Vimeo apps on Android behave like I suggested and it feels very natural. Not sure about iOS but I can check that. Bet this feels natural for iOS users as well but it could also be configurable.

[brianegan]

Yah, OrientationBuilder might not quite work for this one. We might need to use something a bit different, such as a WidgetsBindingObserver + didChangeMetrics function, e.g. https://docs.flutter.io/flutter/widgets/WidgetsBindingObserver/didChangeMetrics.html

And yep, by looking at the platforms, I mean studying how iOS handles rotations with video to make sure the behavior "feels natural" for iOS users as well.

[cbenhagen]

@brianegan any news on this?

[brianegan]

Heya @cbenhagen -- I gave it a shot but my initial attempt didn't quite work out the way I was hoping. I'll try a couple more ideas this week.

[bostrot]

Quickly adding to this conversation that I managed to integrate fullscreen on landscape and leave fullscreen on portrait with a simple Orientation check and some more. I will push it when I have time but here is a little example: https://github.com/bostrot/chewie/blob/master/lib/src/custom_chewie_player.dart

[cbenhagen]

@bostrot Thank you very much! Do you mind adding a pull request on chewie? I think it would be nicer to only have one video player plugin. Maybe you can help @brianegan maintaining? --> #39

[localpcguy]

I'm currently looking into how to make this work via a MethodChannel in iOS so that it will go to landscape in both iOS and Android. It is a requirement for the app I'm working on. If I can get something working (feeling like it is close) I'd be happy to contribute it back.

It may require adding an iOS folder to the plugin though for the MethodChannel implementation (which is where I'm getting stuck at the moment).

[localpcguy]

Just an update on the above - I ended up doing everything in our app code instead of modifying the plugin - setting up the MethodChannel code and changing orientation in response to the event fired when the app goes fullscreen. The plugin doesn't currently have an iOS folder for adding the MethodChannel code currently. I do believe in general, what I did could live in the plugin instead, but I ran out of time to get it implemented there.

[Milansu]

Are there any updates on this? Is there a workaround with the method enterFullScreen() ?