WIP: Fadeout placeholder #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One way to fix the lines might be to just have the same order as before and do a fade-in of the video instead of a fade-out of the placeholder but i'd still love to know why it happens :P |
Closed
|
Gonna close this for now as I think it's been open for a bit and might not apply to the current version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition to fix #31
This solves the black frame at the beginning as well. One thing though: I can see a one pixel (or less?) line of the video loading in the background on the left and right side of the clip even when setting
StackFit.expand. @brianegan do you have an idea why?